Remove NOTIFICATION_RENDER_VIEW_HOST_CHANGED.

Remove NOTIFICATION_RENDER_VIEW_HOST_CHANGED.

Use WebContentsObserver::RenderViewHostChanged() instead.

BUG=170921
Test=No behavioral change.

Sanity checked with JS speech, whether WebContentsTracker class gets created and destroyed properly.

Committed: https://crrev.com/1cf60af0cc6019f03d4cb89c5b3c4788730d3a5e
Cr-Commit-Position: refs/heads/master@{#330213}

[lazyboy, 2015-05-11 18:34:06]

lazyboy@chromium.org changed reviewers:
+ avi@chromium.org

[lazyboy, 2015-05-11 18:34:07]

Adding Avi for review.

[Avi (use Gerrit), 2015-05-11 19:05:00]

lgtm

🎉

https://chromiumcodereview.appspot.com/1132163004/diff/60001/chrome/browser/f...
File chrome/browser/file_select_helper.cc (right):

https://chromiumcodereview.appspot.com/1132163004/diff/60001/chrome/browser/f...
chrome/browser/file_select_helper.cc:554: web_contents_ = NULL;
nullptr

https://chromiumcodereview.appspot.com/1132163004/diff/60001/chrome/browser/u...
File chrome/browser/ui/panels/panel.h (right):

https://chromiumcodereview.appspot.com/1132163004/diff/60001/chrome/browser/u...
chrome/browser/ui/panels/panel.h:35: class RenderViewHost;
If this is only used for the WCO override, can't you rely on the header file to
declare it?

[lazyboy, 2015-05-11 19:22:52]

lazyboy@chromium.org changed reviewers:
+ jianli@chromium.org, thestig@chromium.org, tommi@chromium.org

[lazyboy, 2015-05-11 19:22:53]

+tommi for
chrome_speech_recognition_manager_delegate.cc

+jianli for
chrome/browser/ui/panels/*

+thestig for 
chrome/browser/file_select_helper.*

https://chromiumcodereview.appspot.com/1132163004/diff/60001/chrome/browser/f...
File chrome/browser/file_select_helper.cc (right):

https://chromiumcodereview.appspot.com/1132163004/diff/60001/chrome/browser/f...
chrome/browser/file_select_helper.cc:554: web_contents_ = NULL;
On 2015/05/11 19:05:00, Avi wrote:
> nullptr

Done.

https://chromiumcodereview.appspot.com/1132163004/diff/60001/chrome/browser/u...
File chrome/browser/ui/panels/panel.h (right):

https://chromiumcodereview.appspot.com/1132163004/diff/60001/chrome/browser/u...
chrome/browser/ui/panels/panel.h:35: class RenderViewHost;
On 2015/05/11 19:05:00, Avi wrote:
> If this is only used for the WCO override, can't you rely on the header file
to
> declare it?

Yes, thanks.
Done.

[Lei Zhang, 2015-05-11 19:52:58]

lgtm

https://chromiumcodereview.appspot.com/1132163004/diff/80001/chrome/browser/f...
File chrome/browser/file_select_helper.cc (right):

https://chromiumcodereview.appspot.com/1132163004/diff/80001/chrome/browser/f...
chrome/browser/file_select_helper.cc:88: : content::WebContentsObserver(),
Is this necessary?

[lazyboy, 2015-05-11 20:41:55]

https://chromiumcodereview.appspot.com/1132163004/diff/80001/chrome/browser/f...
File chrome/browser/file_select_helper.cc (right):

https://chromiumcodereview.appspot.com/1132163004/diff/80001/chrome/browser/f...
chrome/browser/file_select_helper.cc:88: : content::WebContentsObserver(),
On 2015/05/11 19:52:58, Lei Zhang wrote:
> Is this necessary?

It's not, I've removed invoking default constructor from here and panel.cc

[lazyboy, 2015-05-13 15:17:15]

ping @jianli and @tommi

[tommi (sloooow) - chröme, 2015-05-14 18:27:57]

lgtm for chrome_speech_recognition_manager_delegate % minor requests

https://chromiumcodereview.appspot.com/1132163004/diff/100001/chrome/browser/...
File chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc
(right):

https://chromiumcodereview.appspot.com/1132163004/diff/100001/chrome/browser/...
chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc:204: int
render_process_id() { return render_process_id_; }
const?

https://chromiumcodereview.appspot.com/1132163004/diff/100001/chrome/browser/...
chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc:222: int
render_process_id_;
can we make these member vars const?

[lazyboy, 2015-05-14 18:48:57]

https://chromiumcodereview.appspot.com/1132163004/diff/100001/chrome/browser/...
File chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc
(right):

https://chromiumcodereview.appspot.com/1132163004/diff/100001/chrome/browser/...
chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc:204: int
render_process_id() { return render_process_id_; }
On 2015/05/14 18:27:57, tommi wrote:
> const?

Done.

https://chromiumcodereview.appspot.com/1132163004/diff/100001/chrome/browser/...
chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc:222: int
render_process_id_;
On 2015/05/14 18:27:57, tommi wrote:
> can we make these member vars const?

Yes, Done.

[jianli, 2015-05-15 19:49:04]

lgtm

[lazyboy, 2015-05-15 22:07:15]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2015-05-15 22:07:15]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
thestig@chromium.org, tommi@chromium.org, jianli@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1132163004/#ps140001 (title: "sync
@tott")

[commit-bot: I haz the power, 2015-05-15 22:07:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1132163004/140001

[commit-bot: I haz the power, 2015-05-15 22:17:15]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-05-18 11:28:18]

Patchset 8 (id:??) landed as
https://crrev.com/1cf60af0cc6019f03d4cb89c5b3c4788730d3a5e
Cr-Commit-Position: refs/heads/master@{#330213}