Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2077)

Unified Diff: chrome/browser/chromeos/extensions/default_app_order_unittest.cc

Issue 11318008: cros: Allow default app order to be loaded from an external file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: for comments in #1 Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/default_app_order_unittest.cc
diff --git a/chrome/browser/chromeos/extensions/default_app_order_unittest.cc b/chrome/browser/chromeos/extensions/default_app_order_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..dee6f52eeae33c0be3caf6e480b424bcea9ca80b
--- /dev/null
+++ b/chrome/browser/chromeos/extensions/default_app_order_unittest.cc
@@ -0,0 +1,121 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/extensions/default_app_order.h"
+
+#include <string>
+#include <vector>
+
+#include "base/file_path.h"
+#include "base/file_util.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/path_service.h"
+#include "base/scoped_temp_dir.h"
+#include "base/test/scoped_path_override.h"
+#include "chrome/common/chrome_paths.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace chromeos {
+
+namespace {
+
+const FilePath::CharType kTestFile[] =
+ FILE_PATH_LITERAL("test_default_app_order.json");
+}
+
+class DefaultAppOrderTest : public testing::Test {
+ public:
+ DefaultAppOrderTest() {}
+ virtual ~DefaultAppOrderTest() {}
+
+ // testing::Test overrides:
+ virtual void SetUp() OVERRIDE {
+ default_app_order::Get(&built_in_default_);
+ }
+ virtual void TearDown() OVERRIDE {
+ }
+
+ bool IsBuiltInDefault(const std::vector<std::string>& apps) {
+ if (apps.size() != built_in_default_.size())
+ return false;
+
+ for (size_t i = 0; i < built_in_default_.size(); ++i) {
+ if (built_in_default_[i] != apps[i])
+ return false;
+ }
+
+ return true;
+ }
+
+ void SetExternalFile(const FilePath& path) {
+ path_override_.reset(new base::ScopedPathOverride(
+ chrome::FILE_DEFAULT_APP_ORDER, path));
+ }
+
+ void CreateExternalOrderFile(const std::string& content) {
+ ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
+ FilePath external_file = temp_dir_.path().Append(kTestFile);
+ file_util::WriteFile(external_file, content.c_str(), content.size());
+ SetExternalFile(external_file);
+ }
+
+ private:
+ std::vector<std::string> built_in_default_;
+
+ ScopedTempDir temp_dir_;
+ scoped_ptr<base::ScopedPathOverride> path_override_;
+
+ DISALLOW_COPY_AND_ASSIGN(DefaultAppOrderTest);
+};
+
+// Tests that the built-in default order is returned when ExternalLoader is not
+// created.
+TEST_F(DefaultAppOrderTest, BuiltInDefault) {
+ std::vector<std::string> apps;
+ default_app_order::Get(&apps);
+ EXPECT_TRUE(IsBuiltInDefault(apps));
+}
+
+// Tests external order file overrides built-in default.
+TEST_F(DefaultAppOrderTest, ExternalOrder) {
+ const char kExternalOrder[] = "[\"app1\",\"app2\",\"app3\"]";
+ CreateExternalOrderFile(std::string(kExternalOrder));
+
+ scoped_ptr<default_app_order::ExternalLoader> loader(
+ new default_app_order::ExternalLoader(false));
+
+ std::vector<std::string> apps;
+ default_app_order::Get(&apps);
+ EXPECT_EQ(3u, apps.size());
+ EXPECT_EQ(std::string("app1"), apps[0]);
+ EXPECT_EQ(std::string("app2"), apps[1]);
+ EXPECT_EQ(std::string("app3"), apps[2]);
+}
+
+// Tests none-existent order file gives built-in default.
+TEST_F(DefaultAppOrderTest, NoExternalFile) {
+ SetExternalFile(FilePath(FILE_PATH_LITERAL("none_existent_file")));
+
+ scoped_ptr<default_app_order::ExternalLoader> loader(
+ new default_app_order::ExternalLoader(false));
+
+ std::vector<std::string> apps;
+ default_app_order::Get(&apps);
+ EXPECT_TRUE(IsBuiltInDefault(apps));
+}
+
+// Tests bad json file gives built-in default.
+TEST_F(DefaultAppOrderTest, BadExternalFile) {
+ const char kExternalOrder[] = "This is not a valid json.";
+ CreateExternalOrderFile(std::string(kExternalOrder));
+
+ scoped_ptr<default_app_order::ExternalLoader> loader(
+ new default_app_order::ExternalLoader(false));
+
+ std::vector<std::string> apps;
+ default_app_order::Get(&apps);
+ EXPECT_TRUE(IsBuiltInDefault(apps));
+}
+
+} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/extensions/default_app_order.cc ('k') | chrome/browser/extensions/extension_sorting.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698