cros: Allow default app order to be loaded from an external file.

chrome/browser/extensions/extension_sorting.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_sorting.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "chrome/browser/extensions/extension_scoped_prefs.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/public/browser/notification_service.h"
 
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/extensions/default_app_order.h"
+#endif
+
 using extensions::ExtensionPrefs;
 
 namespace {
 
 // The number of apps per page. This isn't a hard limit, but new apps installed
 // from the webstore will overflow onto a new page if this limit is reached.
 const size_t kNaturalAppPageSize = 18;
 
 // A preference determining the order of which the apps appear on the NTP.
 const char kPrefAppLaunchIndexDeprecated[] = "app_launcher_index";
@@ skipping 507 matching lines @@
         ClearOrdinals(extension_id);
 
       extension_service_->SyncExtensionChangeIfNeeded(*ext);
     }
   }
 }
 
 void ExtensionSorting::CreateDefaultOrdinals() {
   // The following defines the default order of apps.
 #if defined(OS_CHROMEOS)
-  const char* kDefaultAppOrder[] = {
-    extension_misc::kChromeAppId,
-    extension_misc::kWebStoreAppId,
-    "coobgpohoikkiipiblmjeljniedjpjpf",  // Search
-    "blpcfgokakmgnkcojhhkbfbldkacnbeo",  // Youtube
-    "pjkljhegncpnkpknbcohdijeoejaedia",  // Gmail
-    "ejjicmeblgpmajnghnpcppodonldlgfn",  // Calendar
-    "kjebfhglflhjjjiceimfkgicifkhjlnm",  // Scratchpad
-    "lneaknkopdijkpnocmklfnjbeapigfbh",  // Google Maps
-    "apdfllckaahabafndbhieahigkjlhalf",  // Drive
-    "aohghmighlieiainnegkcijnfilokake",  // Docs
-    "felcaaldnbdncclmgdcncolpebgiejap",  // Sheets
-    "aapocclcgogkmnckokdopfmhonfmgoek",  // Slides
-    "dlppkpafhbajpcmmoheippocdidnckmm",  // Google+
-    "kbpgddbgniojgndnhlkjbkpknjhppkbk",  // Google+ Hangouts
-    "hhaomjibdihmijegdhdafkllkbggdgoj",  // Files
-    "hkhhlkdconhgemhegnplaldnmnmkaemd",  // Tips & Tricks
-    "icppfcnhkcmnfdhfhphakoifcfokfdhg",  // Play Music
-    "mmimngoggfoobjdlefbcabngfnmieonb",  // Play Books
-    "fppdphmgcddhjeddoeghpjefkdlccljb",  // Play Movies
-    "fobcpibfeplaikcclojfdhfdmbbeofai",  // Games
-    "joodangkbfjnajiiifokapkpmhfnpleo",  // Calculator
-    "hfhhnacclhffhdffklopdkcgdhifgngh",  // Camera
-    "gbchcmhmhahfdphkhkmpfmihenigjmpp",  // Chrome Remote Desktop
-  };
+  std::vector<std::string> app_ids;
+  chromeos::default_app_order::Get(&app_ids);
 #else
   const char* kDefaultAppOrder[] = {
     extension_misc::kWebStoreAppId,
   };
+  const std::vector<const char*> app_ids(
+      kDefaultAppOrder, kDefaultAppOrder + arraysize(kDefaultAppOrder));
 #endif
 
   syncer::StringOrdinal page_ordinal = CreateFirstAppPageOrdinal();
   syncer::StringOrdinal app_launch_ordinal =
       CreateFirstAppLaunchOrdinal(page_ordinal);
-  for (size_t i = 0; i < arraysize(kDefaultAppOrder); ++i) {
-    const std::string extension_id = kDefaultAppOrder[i];
+  for (size_t i = 0; i < app_ids.size(); ++i) {
+    const std::string extension_id = app_ids[i];
     default_ordinals_[extension_id].page_ordinal = page_ordinal;
     default_ordinals_[extension_id].app_launch_ordinal = app_launch_ordinal;
     app_launch_ordinal = app_launch_ordinal.CreateAfter();
   }
 }
 
 bool ExtensionSorting::GetDefaultOrdinals(
     const std::string& extension_id,
     syncer::StringOrdinal* page_ordinal,
     syncer::StringOrdinal* app_launch_ordinal) const {
@@ skipping 30 matching lines @@
     ++app_it;
 
   // If there is no next after the collision, returns the next ordinal.
   if (app_it == page.end())
     return app_launch_ordinal.CreateAfter();
 
   // Otherwise, returns the ordinal between the collision and the next ordinal.
   return app_launch_ordinal.CreateBetween(app_it->first);
 }