Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 11316342: [RDS] Temporary workaround for black tabs (Closed)

Created:
8 years ago by gone
Modified:
8 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[RDS] Temporary workaround for black tabs For some reason, this pathway broke recently on Android; it was previously broken on ChromeOS. Comment out the line while the real cause is tracked down. This has the side effect of causing all pages to be zoomed in and scrolled to the top of the page after flipping user agents, but at least the page is usable. BUG=165436 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172528

Patch Set 1 #

Patch Set 2 : Fixing upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
gone
Dave, temporary workaround. Need to track down the real cause but this at least lets ...
8 years ago (2012-12-12 00:33:56 UTC) #1
David Trainor- moved to gerrit
lgtm
8 years ago (2012-12-12 00:35:47 UTC) #2
David Trainor- moved to gerrit
On 2012/12/12 00:35:47, dtrainor wrote: > lgtm Check with Alex/Daniel/Grace or someone to make sure ...
8 years ago (2012-12-12 00:36:02 UTC) #3
gone
+ Alex
8 years ago (2012-12-12 00:36:15 UTC) #4
aelias_OOO_until_Jul13
lgtm
8 years ago (2012-12-12 01:07:58 UTC) #5
gone
+OWNER for content/renderer
8 years ago (2012-12-12 01:09:59 UTC) #6
jamesr
lgtm
8 years ago (2012-12-12 01:11:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/11316342/2001
8 years ago (2012-12-12 01:12:31 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, check_deps, chromeos_unittests, ...
8 years ago (2012-12-12 02:42:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/11316342/2001
8 years ago (2012-12-12 03:17:54 UTC) #10
commit-bot: I haz the power
8 years ago (2012-12-12 04:45:43 UTC) #11
Message was sent while issue was closed.
Change committed as 172528

Powered by Google App Engine
This is Rietveld 408576698