Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 11316338: Add a more generic API for dispatching events from extension EventRouter. (Closed)

Created:
8 years ago by Matt Perry
Modified:
8 years ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Add a more generic API for dispatching events from extension EventRouter. Also fixes a bug where chrome.tabs.oncreated.addlistener is called twice for event pages. The new API allows the caller to specify a callback which gives them a chance to tailor the event args for each extension and Profile. BUG=163246, 162543 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171141

Patch Set 1 #

Total comments: 10

Patch Set 2 : yoz #

Patch Set 3 : compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -127 lines) Patch
M chrome/browser/extensions/browser_event_router.cc View 4 chunks +37 lines, -48 lines 0 comments Download
M chrome/browser/extensions/event_listener_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/event_listener_map_unittest.cc View 1 2 8 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/extensions/event_router.h View 1 7 chunks +56 lines, -24 lines 0 comments Download
M chrome/browser/extensions/event_router.cc View 7 chunks +67 lines, -36 lines 0 comments Download
M chrome/browser/extensions/window_event_router.cc View 1 chunk +8 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Matt Perry
I plan on removing the plethora of DispatchEventToFoo methods in a future CL.
8 years ago (2012-12-04 22:43:55 UTC) #1
Yoyo Zhou
LGTM! https://codereview.chromium.org/11316338/diff/1/chrome/browser/extensions/browser_event_router.cc File chrome/browser/extensions/browser_event_router.cc (right): https://codereview.chromium.org/11316338/diff/1/chrome/browser/extensions/browser_event_router.cc#newcode428 chrome/browser/extensions/browser_event_router.cc:428: event->user_gesture = EventRouter::USER_GESTURE_NOT_ENABLED; Why not USER_GESTURE_UNKNOWN as before? ...
8 years ago (2012-12-04 23:33:14 UTC) #2
Matt Perry
https://codereview.chromium.org/11316338/diff/1/chrome/browser/extensions/browser_event_router.cc File chrome/browser/extensions/browser_event_router.cc (right): https://codereview.chromium.org/11316338/diff/1/chrome/browser/extensions/browser_event_router.cc#newcode428 chrome/browser/extensions/browser_event_router.cc:428: event->user_gesture = EventRouter::USER_GESTURE_NOT_ENABLED; On 2012/12/04 23:33:14, Yoyo Zhou wrote: ...
8 years ago (2012-12-04 23:50:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/11316338/6001
8 years ago (2012-12-04 23:50:38 UTC) #4
commit-bot: I haz the power
Failed to trigger a try job on linux_clang HTTP Error 400: Bad Request
8 years ago (2012-12-05 00:17:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/11316338/9003
8 years ago (2012-12-05 00:17:43 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-05 03:22:50 UTC) #7
Message was sent while issue was closed.
Change committed as 171141

Powered by Google App Engine
This is Rietveld 408576698