Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11316323: Cleanup enums for shelf (Closed)

Created:
8 years ago by oshima
Modified:
8 years ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, Harry McCleave
Visibility:
Public.

Description

Cleanup enums for shelf - move enums from ShelfLayoutManager to shelf_types.h - remove redundant VisibilityState - added SHELF_ prefix to these state. BUG=151417 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171024

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -248 lines) Patch
M ash/ash.gyp View 2 chunks +1 line, -1 line 0 comments Download
M ash/launcher/launcher.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_alignment_menu.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_button_host.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_tooltip_manager.h View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M ash/launcher/launcher_tooltip_manager.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ash/launcher/launcher_tooltip_manager_unittest.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ash/launcher/launcher_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/overflow_bubble.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/overflow_button.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 2 chunks +1 line, -1 line 0 comments Download
A + ash/shelf_types.h View 2 chunks +19 lines, -3 lines 0 comments Download
M ash/shell.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/context_menu.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/context_menu.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/status_area_widget.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/status_area_widget_delegate.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray_item.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_background_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_item_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_views.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/gestures/shelf_gesture_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/shelf_layout_manager.h View 1 6 chunks +19 lines, -31 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 1 20 chunks +61 lines, -59 lines 0 comments Download
M ash/wm/shelf_layout_manager_unittest.cc View 1 29 chunks +69 lines, -68 lines 0 comments Download
D ash/wm/shelf_types.h View 1 chunk +0 lines, -26 lines 0 comments Download
M ash/wm/workspace/workspace_manager_unittest.cc View 1 8 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
8 years ago (2012-12-04 02:47:34 UTC) #1
sky
LGTM
8 years ago (2012-12-04 16:52:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/11316323/8001
8 years ago (2012-12-04 17:06:13 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-04 19:37:37 UTC) #4
Message was sent while issue was closed. 
Change committed as 171024

Powered by Google App Engine
This is Rietveld 408576698