Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 11316320: Replace ProfileIOData::http_server_properties_manager_ with http_server_properties_. (Closed)

Created:
8 years ago by szym
Modified:
8 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Replace ProfileIOData::http_server_properties_manager_ with http_server_properties_. ProfileImplIOData::http_server_properties_manager_ is kept in sync and used to access the implementation. This change moves ownership of HttpServerPropertiesImpl from OffTheRecordProfileIOData to ProfileIOData and ensures http_server_properties_ outlives ChromeURLRequestContexts owned by ProfileIOData. BUG=161832 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171012

Patch Set 1 #

Total comments: 2

Patch Set 2 : responded to willchan's comments in #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M chrome/browser/profiles/off_the_record_profile_io_data.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 5 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 4 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
szym
8 years ago (2012-12-03 23:44:34 UTC) #1
willchan no longer on Chromium
lgtm https://codereview.chromium.org/11316320/diff/1/chrome/browser/profiles/off_the_record_profile_io_data.h File chrome/browser/profiles/off_the_record_profile_io_data.h (right): https://codereview.chromium.org/11316320/diff/1/chrome/browser/profiles/off_the_record_profile_io_data.h#newcode21 chrome/browser/profiles/off_the_record_profile_io_data.h:21: class HttpServerPropertiesImpl; Goodbye https://codereview.chromium.org/11316320/diff/1/chrome/browser/profiles/profile_impl_io_data.h File chrome/browser/profiles/profile_impl_io_data.h (right): https://codereview.chromium.org/11316320/diff/1/chrome/browser/profiles/profile_impl_io_data.h#newcode195 ...
8 years ago (2012-12-03 23:51:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/11316320/8001
8 years ago (2012-12-04 16:13:40 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-04 18:59:04 UTC) #4
Message was sent while issue was closed.
Change committed as 171012

Powered by Google App Engine
This is Rietveld 408576698