Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 11316289: Fix create_nmf warnings (Closed)

Created:
8 years ago by Sam Clegg
Modified:
8 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix create_nmf warnings toolchain option is deprecated. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/test/data/nacl/nacl_browser_test.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/ppapi_untrusted.gyp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Sam Clegg
I should really have fixed these when I changed create_nmf
8 years ago (2012-11-30 22:10:02 UTC) #1
binji
lgtm
8 years ago (2012-11-30 22:10:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/11316289/1
8 years ago (2012-11-30 22:12:16 UTC) #3
commit-bot: I haz the power
Presubmit check for 11316289-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-11-30 22:12:21 UTC) #4
Sam Clegg
+ brad, david
8 years ago (2012-11-30 22:14:01 UTC) #5
dmichael (off chromium)
ppapi/ lgtm
8 years ago (2012-11-30 22:17:55 UTC) #6
Sam Clegg
On 2012/11/30 22:17:55, dmichael wrote: > ppapi/ agtm brad?
8 years ago (2012-12-03 18:31:33 UTC) #7
Sam Clegg
+ncbray
8 years ago (2012-12-03 23:28:08 UTC) #8
Nick Bray (chromium)
LGTM
8 years ago (2012-12-04 00:01:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/11316289/1
8 years ago (2012-12-04 00:09:23 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
8 years ago (2012-12-04 04:16:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/11316289/1
8 years ago (2012-12-04 04:19:29 UTC) #12
commit-bot: I haz the power
8 years ago (2012-12-04 07:23:36 UTC) #13
Message was sent while issue was closed.
Change committed as 170899

Powered by Google App Engine
This is Rietveld 408576698