Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 11316280: Disable CF web server tests temporarily on IE9 (Closed)

Created:
8 years ago by robertshield
Modified:
8 years ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org, amit
Visibility:
Public.

Description

Disable CF web server tests temporarily on IE9 while we hunt down the cause of the first-request failures. BUG=143699 TEST=chrome_frame_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173124

Patch Set 1 #

Patch Set 2 : >=ie9+compile #

Total comments: 2

Patch Set 3 : Dear Greg. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome_frame/test/test_with_web_server.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
robertshield
8 years ago (2012-11-30 20:49:45 UTC) #1
robertshield
On 2012/11/30 20:49:45, robertshield wrote: ptal
8 years ago (2012-11-30 20:55:31 UTC) #2
grt (UTC plus 2)
lgtm https://chromiumcodereview.appspot.com/11316280/diff/6001/chrome_frame/test/test_with_web_server.cc File chrome_frame/test/test_with_web_server.cc (right): https://chromiumcodereview.appspot.com/11316280/diff/6001/chrome_frame/test/test_with_web_server.cc#newcode247 chrome_frame/test/test_with_web_server.cc:247: << "See http://crbug.com/143699"; nit: remove "<<" on this ...
8 years ago (2012-11-30 20:59:18 UTC) #3
robertshield
Thanks! https://chromiumcodereview.appspot.com/11316280/diff/6001/chrome_frame/test/test_with_web_server.cc File chrome_frame/test/test_with_web_server.cc (right): https://chromiumcodereview.appspot.com/11316280/diff/6001/chrome_frame/test/test_with_web_server.cc#newcode247 chrome_frame/test/test_with_web_server.cc:247: << "See http://crbug.com/143699"; On 2012/11/30 20:59:18, grt wrote: ...
8 years ago (2012-11-30 21:05:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/11316280/7004
8 years ago (2012-11-30 21:05:51 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) aura_unittests, content_browsertests, content_unittests, views_unittests
8 years ago (2012-11-30 21:30:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/11316280/7004
8 years ago (2012-12-13 20:21:38 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-13 22:09:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/11316280/7004
8 years ago (2012-12-14 03:24:53 UTC) #9
commit-bot: I haz the power
8 years ago (2012-12-14 07:35:45 UTC) #10
Message was sent while issue was closed.
Change committed as 173124

Powered by Google App Engine
This is Rietveld 408576698