Issue 11316277: Fix linux_aura clang build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11316277: Fix linux_aura clang build. (Closed)

Created:
8 years ago by tfarina

Modified:
8 years ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix linux_aura clang build. Fix the following chromium-style warning: ../../chrome/browser/ui/views/frame/desktop_browser_frame_aura.h:43:3: error: [chromium-style] Overriding method must have "virtual" keyword. By adding the missing 'virtual' keyword. TEST=build/gyp_chromium -Duse_aura=1, ninja -C out/Debug chrome should link. TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170531

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/views/frame/desktop_browser_frame_aura.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11316277/1

8 years ago (2012-11-30 18:07:35 UTC) #2

Message was sent while issue was closed.

Change committed as 170531

Expand Messages | Collapse Messages