Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Unified Diff: content/browser/child_process_launcher.h

Issue 11316261: Linux: inform the Zygote when it's waiting on a dead process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/child_process_launcher.h
diff --git a/content/browser/child_process_launcher.h b/content/browser/child_process_launcher.h
index e28419cec246769be2201ba7ce75132556a44fc6..e247c50ed518be9be641e0c716d5620d6bf0f6d5 100644
--- a/content/browser/child_process_launcher.h
+++ b/content/browser/child_process_launcher.h
@@ -54,10 +54,14 @@ class CONTENT_EXPORT ChildProcessLauncher {
base::ProcessHandle GetHandle();
// Call this when the child process exits to know what happened to
- // it. |exit_code| is the exit code of the process if it exited
- // (e.g. status from waitpid if on posix, from GetExitCodeProcess on
- // Windows). |exit_code| may be NULL.
- base::TerminationStatus GetChildTerminationStatus(int* exit_code);
+ // it.
agl 2012/12/04 15:27:55 looks like "it" fits on the previous line.
jln (very slow on Chromium) 2012/12/04 20:01:25 Done.
+ // |known_dead| can be true if we do already know the process is dead as it
agl 2012/12/04 15:27:55 s/do //
jln (very slow on Chromium) 2012/12/04 20:01:25 Done.
+ // can help the implemention figure the proper TerminationStatus.
+ // |exit_code| is the exit code of the process if it exited (e.g. status from
+ // waitpid if on posix, from GetExitCodeProcess on Windows). |exit_code| may
+ // be NULL.
+ base::TerminationStatus GetChildTerminationStatus(bool known_dead,
+ int* exit_code);
// Changes whether the process runs in the background or not. Only call
// this after the process has started.

Powered by Google App Engine
This is Rietveld 408576698