Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11316244: [content shell] add support for a testRunner.setXSSAuditorEnabled (Closed)

Created:
8 years ago by jochen (gone - plz use gerrit)
Modified:
8 years ago
Reviewers:
jam, marja
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

[content shell] add support for a testRunner.setXSSAuditorEnabled I wanted to wire up a WebPreferences modifying testRunner method, and XSSAuditorEnabled will make >100 tests pass BUG=111316 TEST=most of http/tests/security/xssAuditor passes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170439

Patch Set 1 #

Total comments: 2

Patch Set 2 : updates #

Total comments: 1

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -3 lines) Patch
M content/content_shell.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/renderer/render_view.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M content/shell/shell_messages.h View 1 2 chunks +10 lines, -0 lines 0 comments Download
M content/shell/shell_render_process_observer.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A content/shell/shell_webpreferences.h View 1 1 chunk +28 lines, -0 lines 0 comments Download
A content/shell/shell_webpreferences.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M content/shell/webkit_test_runner.h View 1 3 chunks +4 lines, -0 lines 0 comments Download
M content/shell/webkit_test_runner.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download
M content/shell/webkit_test_runner.js View 2 chunks +4 lines, -0 lines 0 comments Download
M content/shell/webkit_test_runner_bindings.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M content/shell/webkit_test_runner_host.h View 1 4 chunks +4 lines, -0 lines 0 comments Download
M content/shell/webkit_test_runner_host.cc View 1 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
Hey John, can you please review the additional RenderView method? I introduced it to be ...
8 years ago (2012-11-29 16:46:54 UTC) #1
jam
lgtm https://codereview.chromium.org/11316244/diff/1/content/public/renderer/render_view.h File content/public/renderer/render_view.h (right): https://codereview.chromium.org/11316244/diff/1/content/public/renderer/render_view.h#newcode73 content/public/renderer/render_view.h:73: virtual void OverrideWebkitPreferences( nit: probably call it SetWebKitPreferences ...
8 years ago (2012-11-29 17:19:48 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/11316244/diff/1/content/public/renderer/render_view.h File content/public/renderer/render_view.h (right): https://codereview.chromium.org/11316244/diff/1/content/public/renderer/render_view.h#newcode73 content/public/renderer/render_view.h:73: virtual void OverrideWebkitPreferences( On 2012/11/29 17:19:48, John Abd-El-Malek wrote: ...
8 years ago (2012-11-29 19:47:36 UTC) #3
jochen (gone - plz use gerrit)
Marja, can you please review this CL?
8 years ago (2012-11-29 19:47:55 UTC) #4
marja
lgtm https://codereview.chromium.org/11316244/diff/8001/content/public/renderer/render_view.h File content/public/renderer/render_view.h (right): https://codereview.chromium.org/11316244/diff/8001/content/public/renderer/render_view.h#newcode72 content/public/renderer/render_view.h:72: // that the browser process my update the ...
8 years ago (2012-11-30 08:37:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11316244/11001
8 years ago (2012-11-30 09:40:33 UTC) #6
commit-bot: I haz the power
8 years ago (2012-11-30 12:37:17 UTC) #7
Message was sent while issue was closed. 
Change committed as 170439

Powered by Google App Engine
This is Rietveld 408576698