RenderViewImpl::FromRoutingID: Use a global Routing ID map to lookup RenderViews

RenderViewImpl::FromRoutingID: Use a global Routing ID map to lookup RenderViews
from Routing IDs, instead of using ChildThread::ResolveRoute. This avoids a
potentially unsafe downcast from IPC::Listener* to RenderViewImpl*, if the given
routing_id does not correspond to a RenderView.

BUG=163008
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170708

[Matt Giuca, 2012-11-28 01:53:33]

This CL should harden FromRoutingID with a view to exposing it as a public API
(to clients of RenderView) in Issue 11316160.

[Charlie Reis, 2012-11-28 18:09:15]

Thanks!  LGTM, but please run try jobs to be sure it doesn't affect any tests.

[Matt Giuca, 2012-11-28 23:15:21]

On 2012/11/28 18:09:15, creis wrote:
> Thanks!  LGTM, but please run try jobs to be sure it doesn't affect any tests.

Thanks Charlie, but I don't think I have try access just yet (I just tried to
try and all of them gave "failure: -1"). Would you be able to run the try server
for the appropriate targets?

[Charlie Reis, 2012-11-28 23:37:57]

On 2012/11/28 23:15:21, Matt Giuca wrote:
> On 2012/11/28 18:09:15, creis wrote:
> > Thanks!  LGTM, but please run try jobs to be sure it doesn't affect any
tests.
> 
> Thanks Charlie, but I don't think I have try access just yet (I just tried to
> try and all of them gave "failure: -1"). Would you be able to run the try
server
> for the appropriate targets?

Oh.  Are you a provisional committer?  You can usually get that with a
chromium.org account, which should give you the ability to run try jobs. 
Anyway, I launched a few.  Let me know if you need it put into the commit queue
afterward.

[Matt Giuca, 2012-12-03 03:36:38]

I'm having a lot of trouble with linux_rel on the tryserver. It timed out after
about 18 minutes, the two times I was able to run it. It passes on my local
machine, and it looks like lots of other recent runs of the same suite have also
timed out in a similar manner. So someone suggested it might be a tryserver
issue, and I should just submit and do a roll-back if there are any problems.

[commit-bot: I haz the power, 2012-12-03 04:13:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mgiuca@chromium.org/11316209/1

[commit-bot: I haz the power, 2012-12-03 06:48:23]

Change committed as 170708