Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 11316206: NTP5: Re-implementing favicons for Most Visited Pages. (Closed)

Created:
8 years ago by pedro (no code reviews)
Modified:
8 years ago
Reviewers:
dhollowa, Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews), dhollowa+watch_chromium.org, pedrosimonetti+watch_chromium.org
Visibility:
Public.

Description

NTP5: Re-implementing favicons for Most Visited Pages. This is the reimplementation of https://codereview.chromium.org/11416091/, without the merge problems that was introduced in one of the latest Patch Lists. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169841

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -22 lines) Patch
M chrome/browser/resources/ntp_search/new_tab.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/ntp_search/thumbnail_page.css View 3 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/resources/ntp_search/thumbnail_page.js View 2 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/ui/search/search_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
pedro (no code reviews)
Evan, could you please review the ntp_search related code? David, could you please review the ...
8 years ago (2012-11-27 22:56:19 UTC) #1
dhollowa
c/b/ui/search/... lgtm.
8 years ago (2012-11-27 23:07:52 UTC) #2
Evan Stade
lgtm, except the description should not say NTP4
8 years ago (2012-11-27 23:29:10 UTC) #3
pedro (no code reviews)
On 2012/11/27 23:29:10, Evan Stade wrote: > lgtm, except the description should not say NTP4 ...
8 years ago (2012-11-27 23:47:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pedrosimonetti@chromium.org/11316206/1
8 years ago (2012-11-28 00:15:51 UTC) #5
commit-bot: I haz the power
Retried try job too often for step(s) aura_unit_tests
8 years ago (2012-11-28 02:03:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pedrosimonetti@chromium.org/11316206/1
8 years ago (2012-11-28 02:30:13 UTC) #7
commit-bot: I haz the power
8 years ago (2012-11-28 04:17:25 UTC) #8
Message was sent while issue was closed.
Change committed as 169841

Powered by Google App Engine
This is Rietveld 408576698