Issue 11316202: Properly handle-ify method calls to map() and GetLocalElementAccessorPair()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11316202: Properly handle-ify method calls to map() and GetLocalElementAccessorPair() (Closed)

Created:
8 years ago by adamk

Modified:
8 years ago

Reviewers:
rossberg, Toon Verwaest

CC:
v8-dev, rafaelw

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Properly handle-ify method calls to map() and GetLocalElementAccessorPair() These are likely causing some of the flaky crashes in Object.observe code. I've reorganized some of the code to minimize the number of necessary calls to map() (by saving the result of map()->is_observed() in a local bool). Also move down an unnecessarily early call to Uint32ToString when sending an element deletion notification. Committed: https://code.google.com/p/v8/source/detail?r=13070

Patch Set 1 #

Patch Set 2 : Also fix calls to map() #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -18 lines)			Patch
	M	src/objects.cc	View	1	7 chunks	+17 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm. Nice cleanup, landing.

Expand Messages | Collapse Messages