Issue 11316168: Ensure we do not clobber the register holding the elements backing store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11316168: Ensure we do not clobber the register holding the elements backing store. (Closed)

Created:
8 years ago by Toon Verwaest

Modified:
8 years ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Ensure we do not clobber the register holding the elements backing store. Committed: https://code.google.com/p/v8/source/detail?r=13061

Patch Set 2 : Use r9 instead of r8, given that r8 is the context register #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -2 lines)			Patch
	M	src/arm/stub-cache-arm.cc	View	1	3 chunks	+7 lines, -2 lines	0 comments	Download
	M	test/mjsunit/regress/regress-crbug-162085.js	View		3 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

danno

https://chromiumcodereview.appspot.com/11316168/diff/1/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): https://chromiumcodereview.appspot.com/11316168/diff/1/src/arm/stub-cache-arm.cc#newcode4698 src/arm/stub-cache-arm.cc:4698: // -- r8 : scratch r8 is the context ...

8 years ago (2012-11-26 15:31:50 UTC) #2

Toon Verwaest

addressed comment. https://chromiumcodereview.appspot.com/11316168/diff/1/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): https://chromiumcodereview.appspot.com/11316168/diff/1/src/arm/stub-cache-arm.cc#newcode4698 src/arm/stub-cache-arm.cc:4698: // -- r8 : scratch On 2012/11/26 ...

8 years ago (2012-11-26 15:36:33 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 11316168: Ensure we do not clobber the register holding the elements backing store. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Use r9 instead of r8, given that r8 is the context register #

Messages