Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: chrome/browser/prefs/mock_pref_change_callback.h

Issue 11316163: Remove the last usages of PrefObserver outside of Prefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PREFS_PREF_OBSERVER_MOCK_H_ 5 #ifndef CHROME_BROWSER_PREFS_MOCK_PREF_CHANGE_CALLBACK_H_
6 #define CHROME_BROWSER_PREFS_PREF_OBSERVER_MOCK_H_ 6 #define CHROME_BROWSER_PREFS_MOCK_PREF_CHANGE_CALLBACK_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/prefs/public/pref_observer.h" 10 #include "base/prefs/public/pref_change_registrar.h"
11 #include "chrome/browser/prefs/pref_service.h" 11 #include "chrome/browser/prefs/pref_service.h"
12 #include "testing/gmock/include/gmock/gmock.h" 12 #include "testing/gmock/include/gmock/gmock.h"
13 13
14 using testing::Pointee; 14 using testing::Pointee;
15 using testing::Property; 15 using testing::Property;
16 using testing::Truly; 16 using testing::Truly;
17 17
18 // Matcher that checks whether the current value of the preference named 18 // Matcher that checks whether the current value of the preference named
19 // |pref_name| in |prefs| matches |value|. If |value| is NULL, the matcher 19 // |pref_name| in |prefs| matches |value|. If |value| is NULL, the matcher
20 // checks that the value is not set. 20 // checks that the value is not set.
21 MATCHER_P3(PrefValueMatches, prefs, pref_name, value, "") { 21 MATCHER_P3(PrefValueMatches, prefs, pref_name, value, "") {
22 const PrefServiceBase::Preference* pref = 22 const PrefServiceBase::Preference* pref =
23 prefs->FindPreference(pref_name.c_str()); 23 prefs->FindPreference(pref_name.c_str());
24 if (!pref) 24 if (!pref)
25 return false; 25 return false;
26 26
27 const Value* actual_value = pref->GetValue(); 27 const Value* actual_value = pref->GetValue();
28 if (!actual_value) 28 if (!actual_value)
29 return value == NULL; 29 return value == NULL;
30 if (!value) 30 if (!value)
31 return actual_value == NULL; 31 return actual_value == NULL;
32 return value->Equals(actual_value); 32 return value->Equals(actual_value);
33 } 33 }
34 34
35 // A mock for testing preference notifications and easy setup of expectations. 35 // A mock for testing preference notifications and easy setup of expectations.
36 class PrefObserverMock : public PrefObserver { 36 class MockPrefChangeCallback {
37 public: 37 public:
38 PrefObserverMock(); 38 explicit MockPrefChangeCallback(PrefServiceBase* prefs);
39 virtual ~PrefObserverMock(); 39 virtual ~MockPrefChangeCallback();
40 40
41 MOCK_METHOD2(OnPreferenceChanged, void(PrefServiceBase*, const std::string&)); 41 PrefChangeRegistrar::NamedChangeCallback GetCallback();
42 42
43 void Expect(PrefServiceBase* prefs, 43 MOCK_METHOD1(OnPreferenceChanged, void(const std::string&));
44 const std::string& pref_name, 44
45 void Expect(const std::string& pref_name,
45 const Value* value); 46 const Value* value);
47
48 private:
49 PrefServiceBase* prefs_;
46 }; 50 };
47 51
48 #endif // CHROME_BROWSER_PREFS_PREF_OBSERVER_MOCK_H_ 52 #endif // CHROME_BROWSER_PREFS_MOCK_PREF_CHANGE_CALLBACK_H_
OLDNEW
« no previous file with comments | « chrome/browser/plugins/plugin_status_pref_setter.cc ('k') | chrome/browser/prefs/mock_pref_change_callback.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698