Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: content/renderer/render_view_impl.cc

Issue 11316160: app.window: Replace linear view search with direct lookup. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: render_view_impl: Changed the FromRoutingID function into static method RenderViewImpl::FromRouting… Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index b56a17eb6b246ed3da4a9dcc1eb18b42a781c1c4..95a4eda7909a0d3c4a9705f2f989dc79d55ad289 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -371,12 +371,6 @@ static const size_t kContentIntentDelayMilliseconds = 700;
static RenderViewImpl* (*g_create_render_view_impl)(RenderViewImplParams*) =
NULL;
-static RenderViewImpl* FromRoutingID(int32 routing_id) {
- RoutingIDViewMap* views = g_routing_id_view_map.Pointer();
- RoutingIDViewMap::iterator it = views->find(routing_id);
- return it == views->end() ? NULL : it->second;
-}
-
static WebKit::WebFrame* FindFrameByID(WebKit::WebFrame* root, int frame_id) {
for (WebFrame* frame = root; frame; frame = frame->traverseNext(false)) {
if (frame->identifier() == frame_id)
@@ -785,6 +779,18 @@ RenderView* RenderView::FromWebView(WebKit::WebView* webview) {
}
/*static*/
+RenderViewImpl* RenderViewImpl::FromRoutingID(int32 routing_id) {
+ RoutingIDViewMap* views = g_routing_id_view_map.Pointer();
+ RoutingIDViewMap::iterator it = views->find(routing_id);
+ return it == views->end() ? NULL : it->second;
+}
+
+/*static*/
+RenderView* RenderView::FromRoutingID(int routing_id) {
+ return RenderViewImpl::FromRoutingID(routing_id);
+}
+
+/*static*/
void RenderView::ForEach(RenderViewVisitor* visitor) {
ViewMap* views = g_view_map.Pointer();
for (ViewMap::iterator it = views->begin(); it != views->end(); ++it) {
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698