Issue 11316151: Revert r13025 and r13026 (they introduced a bug on arm and regressed octane crypto).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11316151: Revert r13025 and r13026 (they introduced a bug on arm and regressed octane crypto). (Closed)

Created:
8 years, 1 month ago by Massi

Modified:
8 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert r13025 and r13026 (they introduced a bug on arm and regressed octane crypto). BUG= Committed: https://code.google.com/p/v8/source/detail?r=13039

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -145 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/hydrogen.cc	View	2 chunks	+13 lines, -66 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	4 chunks	+2 lines, -6 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ic.cc	View	2 chunks	+20 lines, -11 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/array-length.js	View	2 chunks	+0 lines, -41 lines	0 comments	Download

Total messages: 2 (0 generated)

Massi

This is a plain "git revert" which had no conflicts, builds and passes make check...

8 years, 1 month ago (2012-11-23 10:19:26 UTC) #1

rubber-stamp LGTM