Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 11316139: Beginnings of moving more stuff from build_sdk.py to GYP. (Closed)

Created:
8 years, 1 month ago by binji
Modified:
8 years ago
Reviewers:
noelallen1
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Beginnings of moving more stuff from build_sdk.py to GYP. Adds a new target to all.gyp: chromium_builder_nacl_sdk Adds a native_client_sdk gyp file: it depends on nacl_core_sdk from the native_client repo, but also builds and copies ppapi libraries to the toolchain directories. Retry of https://codereview.chromium.org/11413075/. This one failed because I didn't check for disable_nacl=1. Which was a retry of http://codereview.chromium.org/11299081/. Which was a retry of http://codereview.chromium.org/11363045/. Failed both of these times because of a separate NaCl build issue that was resolved by http://crrev.com/168621. BUG=none TBR=noelallen@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169532

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -0 lines) Patch
M build/all.gyp View 1 chunk +20 lines, -0 lines 0 comments Download
A native_client_sdk/src/build_tools/nacl_ppapi_sdk.gyp View 1 chunk +130 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/11316139/1
8 years, 1 month ago (2012-11-21 18:55:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/11316139/1
8 years ago (2012-11-26 21:21:41 UTC) #2
commit-bot: I haz the power
8 years ago (2012-11-26 23:41:45 UTC) #3
Message was sent while issue was closed.
Change committed as 169532

Powered by Google App Engine
This is Rietveld 408576698