Issue 11316048: Hide error bubbles after a successful sign-in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11316048: Hide error bubbles after a successful sign-in. (Closed)

Created:
8 years, 1 month ago by Joao da Silva

Modified:
8 years, 1 month ago

Reviewers:
Nikita (slow), pastarmovj

CC:
chromium-reviews, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Hide error bubbles after a successful sign-in. This hides the user-not-whitelisted error from a previous login, for example. BUG=161360 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168235

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/settings/stub_cros_settings_provider.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/resources/chromeos/login/screen_gaia_signin.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

@pastarmovj: please review the stub_cros_settings change. The desktop build crashes if launched with --stub-cros-settings without ...

8 years, 1 month ago (2012-11-16 14:41:11 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/11316048/1

8 years, 1 month ago (2012-11-16 16:26:34 UTC) #4

Change committed as 168235

Expand Messages | Collapse Messages