- Move MathNatives from dart:core to dart:math.

runtime/vm/scanner.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/scanner.h"
 
 #include "platform/assert.h"
 #include "vm/flags.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
@@ skipping 156 matching lines @@
   }
   for (int i =  1; i < str.Length(); i++) {
     if (!IsIdentChar(str.CharAt(i))) {
       return false;
     }
   }
   return true;
 }
 
 
+// TODO(srdjan): Investigate for performance hit; the integer and double parsing
+// may not be efficient as we need to generate two extra growable arrays.

[siva, 2012/11/16 01:34:26]

This comment here does not seem to make sense?

[Ivan Posva, 2012/11/16 19:26:43]

Adjusted comment explaining what this method is for.

+bool Scanner::IsValidLiteral(const Scanner::GrowableTokenStream& tokens,
+                           Token::Kind literal_kind,

[Mads Ager (google), 2012/11/16 05:46:21]

Indentation is slightly off.

[Ivan Posva, 2012/11/16 19:26:43]

Done.

+                           bool* is_positive,
+                           String** value) {
+  if ((tokens.length() == 2) &&
+      (tokens[0].kind == literal_kind) &&
+      (tokens[1].kind == Token::kEOS)) {
+    *is_positive = true;
+    *value = tokens[0].literal;
+    return true;
+  }
+  if ((tokens.length() == 3) &&
+      ((tokens[0].kind == Token::kTIGHTADD) ||
+          (tokens[0].kind == Token::kSUB)) &&

[Mads Ager (google), 2012/11/16 05:46:21]

Indentation sligthly off.

[Ivan Posva, 2012/11/16 19:26:43]

Done.

+      (tokens[1].kind == literal_kind) &&
+      (tokens[2].kind == Token::kEOS)) {
+    // Check there is no space between "+/-" and number.
+    if ((tokens[0].offset + 1) != tokens[1].offset) {
+      return false;
+    }
+    *is_positive = tokens[0].kind == Token::kTIGHTADD;
+    *value = tokens[1].literal;
+    return true;
+  }
+  return false;
+}
+
+
 void Scanner::ReadChar() {
   if (lookahead_pos_ < source_length_) {
     if (c0_ == '\n') {
       newline_seen_ = true;
       c0_pos_.line++;
       c0_pos_.column = 0;
       if (source_.CharAt(lookahead_pos_) == '\r') {
         // Replace a sequence of '\r' '\n' with a single '\n'.
         if (LookaheadChar(1) == '\n') {
           lookahead_pos_++;
@@ skipping 765 matching lines @@
               "%c%#"Px"", kPrivateKeySeparator, key_value);
   const String& result = String::Handle(String::New(private_key, Heap::kOld));
   return result.raw();
 }
 
 
 void Scanner::InitOnce() {
 }
 
 }  // namespace dart