- Move MathNatives from dart:core to dart:math.

runtime/lib/integers.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/dart_entry.h"
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
+#include "vm/symbols.h"
 
 namespace dart {
 
 DEFINE_FLAG(bool, trace_intrinsified_natives, false,
     "Report if any of the intrinsified natives are called");
 
 // Smi natives.
 
 // Returns false if integer is in wrong representation, e.g., as is a Bigint
 // when it could have been a Smi.
@@ skipping 143 matching lines @@
   ASSERT(CheckInteger(left));
   ASSERT(CheckInteger(right));
   if (FLAG_trace_intrinsified_natives) {
     OS::Print("Integer_equalToInteger %s == %s\n",
         left.ToCString(), right.ToCString());
   }
   return Bool::Get(left.CompareWith(right) == 0);
 }
 
 
+DEFINE_NATIVE_ENTRY(Integer_parse, 1) {
+  GET_NATIVE_ARGUMENT(String, value, arguments->NativeArgAt(0));
+  const String& dummy_key = String::Handle(Symbols::Empty());
+  Scanner scanner(value, dummy_key);
+  const Scanner::GrowableTokenStream& tokens = scanner.GetStream();
+  String* int_string;
+  bool is_positive;
+  if (Scanner::IsValidLiteral(tokens,
+                             Token::kINTEGER,
+                             &is_positive,
+                             &int_string)) {
+    if (is_positive) {
+      return Integer::New(*int_string);
+    } else {
+      String& temp = String::Handle();
+      temp = String::Concat(String::Handle(Symbols::New("-")),
+                            *int_string);
+      return Integer::New(temp);
+    }
+  } else {

[siva, 2012/11/16 01:34:26]

Is the else needed here? It could be similar to the way
it is coded in Double_parse

[Ivan Posva, 2012/11/16 19:26:43]

Done here and in similar places such as line 189 above.

+    GrowableArray<const Object*> args;
+    args.Add(&value);
+    Exceptions::ThrowByType(Exceptions::kFormat, args);
+    return Object::null();
+  }
+}
+
+
 static RawInteger* ShiftOperationHelper(Token::Kind kind,
                                         const Integer& value,
                                         const Smi& amount) {
   if (amount.Value() < 0) {
     GrowableArray<const Object*> args;
     args.Add(&amount);
     Exceptions::ThrowByType(Exceptions::kArgument, args);
   }
   if (value.IsSmi()) {
     Smi& smi_value = Smi::Handle();
@@ skipping 86 matching lines @@
 
 DEFINE_NATIVE_ENTRY(Bigint_bitNegate, 1) {
   const Bigint& value = Bigint::CheckedHandle(arguments->NativeArgAt(0));
   const Bigint& result = Bigint::Handle(BigintOperations::BitNot(value));
   ASSERT(CheckInteger(value));
   ASSERT(CheckInteger(result));
   return result.AsInteger();
 }
 
 }  // namespace dart