Add attribute information table so we generate correct setters.

lib/src/emitters.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** Collects several code emitters for the template tool. */
 // TODO(sigmund): add visitor that applies all emitters on a component
 // TODO(sigmund): add support for conditionals, so context is changed at that
 // point.
 library emitters;
 
 import 'package:html5lib/dom.dart';
 import 'package:html5lib/dom_parsing.dart';
 // TODO(jmesserly): this utility should be somewhere else.
 import 'package:html5lib/src/utils.dart' show reversed;
 
 import 'code_printer.dart';
 import 'codegen.dart' as codegen;
 import 'file_system/path.dart';
 import 'files.dart';
 import 'html5_utils.dart';
+import 'html5_setters.g.dart';
 import 'info.dart';
 import 'messages.dart';
 import 'utils.dart';
 
 /**
  * An emitter for a web component feature.  It collects all the logic for
  * emitting a particular feature (such as data-binding, event hookup) with
  * respect to a single HTML element.
  */
 abstract class Emitter<T extends ElementInfo> {
@@ skipping 52 matching lines @@
 }
 
 /**
  * Generates a field for any element that has either event listeners or data
  * bindings.
  */
 class ElementFieldEmitter extends Emitter<ElementInfo> {
   ElementFieldEmitter(ElementInfo info) : super(info);
 
   void emitDeclarations(Context context) {
-    var type = htmlElementNames[elem.tagName];
-    // Note: this will eventually be the component's class name if it is a
-    // known x-tag.
-    if (type == null) type = 'UnknownElement';
+    var type = typeForHtmlTag(elem.tagName);
     context.declarations.add('autogenerated.$type ${elemInfo.identifier};');
   }
 
   void emitCreated(Context context) {
     // TODO(jmesserly): there's an asymmetry here. In one case, the child is
     // already in the document but not in the other case.
     if (elemInfo.needsQuery) {
       var parentId = '_root';
       for (var p = elemInfo.parent; p != null; p = p.parent) {
         if (p.identifier != null) {
@@ skipping 116 matching lines @@
                 if (e.oldValue != null && e.oldValue != '') {
                   $elemField.classes.remove(e.oldValue);
                 }
                 if (e.newValue != null && e.newValue != '') {
                   $elemField.classes.add(e.newValue);
                 }
               });
           ''');
         }
       } else {
+        // Note: it is important for correctness to use the DOM setter if it
+        // is available. Otherwise changes will not be applied. This is most
+        // easily observed with "InputElement.value", ".checked", etc.
+        var setter = null;
+        var typeName = typeForHtmlTag(elem.tagName);
+        while (typeName != null) {
+          var fields = htmlElementFields[typeName];
+          if (fields != null) setter = fields[name];
+          if (setter != null) break;
+          typeName = htmlElementExtends[typeName];

[Siggi Cherem (dart-lang), 2012/11/06 03:20:36]

emulating dart semantics, yay!  -- sarcasm ;-)

[Jennifer Messerly, 2012/11/06 03:51:57]

Hah, yeah :\. OTOH, it's kind of Web IDL semantics, so it's not as bad as it
looks :)

+        }
+        if (setter == null) setter = 'attributes["$name"]';
+
         var val = attrInfo.boundValue;
         var stopperName = attrInfo.stopperNames[0];
-        var setter;
-        // TODO(sigmund): use setters when they are available (issue #112)
-        //                Need to know if an attr is known for an element.
-        if ((elem.tagName == 'input' &&
-             (name == 'value' || name == 'checked')) ||
-            name == 'hidden') {
-          setter = name;
-        } else {
-          setter = 'attributes["$name"]';
-        }
         context.insertedMethod.add('''
             $stopperName = autogenerated.watchAndInvoke(() => $val, (e) {
             $elemField.$setter = e.newValue;
-            });
-        ''');
+            });''');
       }
     });
 
     // Emit functions for any data-bound content on this element or children of
     // this element.
     _emitContentWatchInvoke(context, elemInfo, elemField);
     for (var childInfo in elemInfo.children) {
       _emitContentWatchInvoke(context, childInfo, elemField);
     }
   }
@@ skipping 477 matching lines @@
 void _emitHtmlElement(CodePrinter method, ElementInfo info) {
   // http://dev.w3.org/html5/spec/namespaces.html#namespaces
   const htmlNamespace = 'http://www.w3.org/1999/xhtml';
 
   var node = info.node;
 
   // Generate precise types like "new ButtonElement()" if we can.
   if (node.attributes.length == 0 && node.nodes.length == 0 &&
       node.namespace == htmlNamespace) {
 
     var elementName = htmlElementNames[node.tagName];

[Siggi Cherem (dart-lang), 2012/11/06 03:20:36]

you probably want to fix it here too

[Jennifer Messerly, 2012/11/06 03:51:57]

I don't think "new autogenerated.UnknownElement" would do the right thing,
though. I'll leave this alone since your change affects it too :)

     if (elementName != null) {
       method.add("${info.identifier} = new autogenerated.$elementName();");
       return;
     }
   }
 
   method.add("${info.identifier} = new autogenerated.Element.html('''")
       .addRaw(escapeDartString(node.outerHTML, triple: true))
       .add("''');");
 }