Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: sync/sessions/sync_session.h

Issue 11314008: sync: Follow-up to conflict resolution refactor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/sessions/status_controller_unittest.cc ('k') | sync/sessions/sync_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/sessions/sync_session.h
diff --git a/sync/sessions/sync_session.h b/sync/sessions/sync_session.h
index 4026e88aa9b602ba1f4e17899729ad7799d0691e..19cba8cd682f2569bae5fb9dcd8e08f39db8d1dd 100644
--- a/sync/sessions/sync_session.h
+++ b/sync/sessions/sync_session.h
@@ -27,7 +27,6 @@
#include "sync/internal_api/public/engine/model_safe_worker.h"
#include "sync/internal_api/public/sessions/sync_session_snapshot.h"
#include "sync/sessions/ordered_commit_set.h"
-#include "sync/sessions/session_state.h"
#include "sync/sessions/status_controller.h"
#include "sync/sessions/sync_session_context.h"
#include "sync/util/extensions_activity_monitor.h"
@@ -108,10 +107,6 @@ class SyncSession {
// Builds and sends a snapshot to the session context's listeners.
void SendEventNotification(SyncEngineEvent::EventCause cause);
- // Returns true if this session contains data that should go through the sync
- // engine again.
- bool HasMoreToSync() const;
-
// Returns true if we reached the server. Note that "reaching the server"
// here means that from an HTTP perspective, we succeeded (HTTP 200). The
// server **MAY** have returned a sync protocol error.
@@ -133,10 +128,6 @@ class SyncSession {
const ModelSafeRoutingInfo& routing_info,
const std::vector<ModelSafeWorker*>& workers);
- // Should be called any time |this| is being re-used in a new call to
- // SyncShare (e.g., HasMoreToSync returned true).
- void PrepareForAnotherSyncCycle();
-
// TODO(akalin): Split this into context() and mutable_context().
SyncSessionContext* context() const { return context_; }
Delegate* delegate() const { return delegate_; }
@@ -162,9 +153,6 @@ class SyncSession {
// Returns the set of groups which have enabled types.
const std::set<ModelSafeGroup>& GetEnabledGroups() const;
- // Returns the set of enabled groups that have conflicts.
- std::set<ModelSafeGroup> GetEnabledGroupsWithConflicts() const;
-
private:
// Extend the encapsulation boundary to utilities for internal member
// assignments. This way, the scope of these actions is explicit, they can't
« no previous file with comments | « sync/sessions/status_controller_unittest.cc ('k') | sync/sessions/sync_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698