Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: sync/internal_api/public/sessions/sync_session_snapshot.cc

Issue 11314008: sync: Follow-up to conflict resolution refactor (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/public/sessions/sync_session_snapshot.cc
diff --git a/sync/internal_api/public/sessions/sync_session_snapshot.cc b/sync/internal_api/public/sessions/sync_session_snapshot.cc
index 193a5afafa77bc09a8790a1b4c1adbf93edfcdc3..e93e008cf753c5c6c501c2bedfde96a7f5e6fa32 100644
--- a/sync/internal_api/public/sessions/sync_session_snapshot.cc
+++ b/sync/internal_api/public/sessions/sync_session_snapshot.cc
@@ -13,11 +13,9 @@ namespace sessions {
SyncSessionSnapshot::SyncSessionSnapshot()
: is_share_usable_(false),
- has_more_to_sync_(false),
is_silenced_(false),
num_encryption_conflicts_(0),
num_hierarchy_conflicts_(0),
- num_simple_conflicts_(0),
num_server_conflicts_(0),
notifications_enabled_(false),
num_entries_(0),
@@ -29,11 +27,9 @@ SyncSessionSnapshot::SyncSessionSnapshot(
bool is_share_usable,
ModelTypeSet initial_sync_ended,
const ProgressMarkerMap& download_progress_markers,
- bool more_to_sync,
bool is_silenced,
int num_encryption_conflicts,
int num_hierarchy_conflicts,
- int num_simple_conflicts,
int num_server_conflicts,
const SyncSourceInfo& source,
bool notifications_enabled,
@@ -43,11 +39,9 @@ SyncSessionSnapshot::SyncSessionSnapshot(
is_share_usable_(is_share_usable),
initial_sync_ended_(initial_sync_ended),
download_progress_markers_(download_progress_markers),
- has_more_to_sync_(more_to_sync),
is_silenced_(is_silenced),
num_encryption_conflicts_(num_encryption_conflicts),
num_hierarchy_conflicts_(num_hierarchy_conflicts),
- num_simple_conflicts_(num_simple_conflicts),
num_server_conflicts_(num_server_conflicts),
source_(source),
notifications_enabled_(notifications_enabled),
@@ -82,15 +76,12 @@ DictionaryValue* SyncSessionSnapshot::ToValue() const {
ModelTypeSetToValue(initial_sync_ended_));
value->Set("downloadProgressMarkers",
ProgressMarkerMapToValue(download_progress_markers_).release());
- value->SetBoolean("hasMoreToSync", has_more_to_sync_);
value->SetBoolean("isSilenced", is_silenced_);
// We don't care too much if we lose precision here, also.
value->SetInteger("numEncryptionConflicts",
num_encryption_conflicts_);
value->SetInteger("numHierarchyConflicts",
num_hierarchy_conflicts_);
- value->SetInteger("numSimpleConflicts",
- num_simple_conflicts_);
value->SetInteger("numServerConflicts",
num_server_conflicts_);
value->SetInteger("numEntries", num_entries_);
@@ -125,10 +116,6 @@ const ProgressMarkerMap&
return download_progress_markers_;
}
-bool SyncSessionSnapshot::has_more_to_sync() const {
- return has_more_to_sync_;
-}
-
bool SyncSessionSnapshot::is_silenced() const {
return is_silenced_;
}
@@ -141,10 +128,6 @@ int SyncSessionSnapshot::num_hierarchy_conflicts() const {
return num_hierarchy_conflicts_;
}
-int SyncSessionSnapshot::num_simple_conflicts() const {
- return num_simple_conflicts_;
-}
-
int SyncSessionSnapshot::num_server_conflicts() const {
return num_server_conflicts_;
}

Powered by Google App Engine
This is Rietveld 408576698