runtime/bin/utils_win.cc - Issue 11312242: Revised CL for customisable logging (replacing printfs).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/utils_win.cc

Issue 11312242: Revised CL for customisable logging (replacing printfs). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/utils_win.cc

===================================================================

--- runtime/bin/utils_win.cc (revision 14977)

+++ runtime/bin/utils_win.cc (working copy)

@@ -4,6 +4,7 @@

#include <errno.h>

+#include "bin/log.h"

#include "bin/utils.h"

Ivan Posva 2012/11/17 01:13:42 ditto

gram 2012/11/19 17:38:56 Done.

static void FormatMessageIntoBuffer(DWORD code,

@@ -19,7 +20,7 @@

NULL);

if (message_size == 0) {

if (GetLastError() != ERROR_INSUFFICIENT_BUFFER) {

- fprintf(stderr, "FormatMessage failed %d\n", GetLastError());

+ Log::PrintErr("FormatMessage failed %d\n", GetLastError());

}

snprintf(buffer, buffer_length, "OS Error %d", code);

}

« runtime/bin/socket_android.cc ('K') | « runtime/bin/socket_win.cc ('k') | no next file » | no next file with comments »