Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 11312225: Fix Chrome logo to transition smoothly between the demo login screen and login spinner. (Closed)

Created:
8 years, 1 month ago by rkc
Modified:
8 years, 1 month ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Fix Chrome logo to transition smoothly between the demo login screen and login spinner. R=dpolukhin@chromium.org BUG=160433 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167599

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : removed unused image file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M chrome/browser/resources/chromeos/login/demo_user_login.css View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/demo_user_login.html View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/demo_user_login.js View 1 chunk +1 line, -5 lines 0 comments Download
D chrome/browser/resources/chromeos/login/images/chrome_center_logo.jpg View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rkc
8 years, 1 month ago (2012-11-14 01:19:00 UTC) #1
dpolukhin
LGTM Please remove unused image file.
8 years, 1 month ago (2012-11-14 01:22:43 UTC) #2
rkc
Removed unused image file.
8 years, 1 month ago (2012-11-14 01:24:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/11312225/4001
8 years, 1 month ago (2012-11-14 01:25:00 UTC) #4
commit-bot: I haz the power
Presubmit check for 11312225-4001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-11-14 01:25:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/11312225/4001
8 years, 1 month ago (2012-11-14 01:29:23 UTC) #6
commit-bot: I haz the power
Presubmit check for 11312225-4001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 1 month ago (2012-11-14 01:29:27 UTC) #7
Dmitry Polukhin
LGTM
8 years, 1 month ago (2012-11-14 01:29:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/11312225/4001
8 years, 1 month ago (2012-11-14 01:30:54 UTC) #9
commit-bot: I haz the power
8 years, 1 month ago (2012-11-14 05:04:21 UTC) #10
Change committed as 167599

Powered by Google App Engine
This is Rietveld 408576698