C++ readability review for lazyboy@

content/browser/web_contents/web_contents_impl.cc

Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 99d7e60608450a10637fcb790d36e0b88dbc3fe4..52aa3cf04318f658fcf96712b1d5c4350d7b0a5e 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -1305,8 +1305,10 @@ void WebContentsImpl::CreateNewWindow(
     int instance_id = GetBrowserPluginGuestManager()->get_next_instance_id();
     WebContentsImpl* new_contents_impl =
         static_cast<WebContentsImpl*>(new_contents);
-    BrowserPluginGuest::CreateWithOpener(instance_id, new_contents_impl,
-        GetBrowserPluginGuest(), !!new_contents_impl->opener());
+    BrowserPluginGuest::CreateWithOpener(instance_id,
+                                         !!new_contents_impl->opener(),

[smo, 2013/11/13 01:50:54]

(optional)

I'd either stick with the existing style of implicit casts (i.e., this without
the "!!") or do "!= NULL" explicitly.

[lazyboy, 2013/11/13 02:07:29]

Changed to != NULL

+                                         new_contents_impl,
+                                         GetBrowserPluginGuest());
   }
   if (params.disposition == NEW_BACKGROUND_TAB)
     create_params.initially_hidden = true;