content/browser/browser_plugin/test_browser_plugin_guest.cc - Issue 11312179: C++ readability review for lazyboy@

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/test_browser_plugin_guest.cc

Issue 11312179: C++ readability review for lazyboy@ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments (round 2). Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/browser_plugin/test_browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/test_browser_plugin_guest.cc b/content/browser/browser_plugin/test_browser_plugin_guest.cc

index 24a234127b88f7bca7e72107dce5a9fb3965279d..63237b390eaec9f7b7e157e909fcee40aeb2b562 100644

--- a/content/browser/browser_plugin/test_browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/test_browser_plugin_guest.cc

@@ -16,7 +16,7 @@ class BrowserPluginGuest;

TestBrowserPluginGuest::TestBrowserPluginGuest(

int instance_id,

WebContentsImpl* web_contents)

- : BrowserPluginGuest(instance_id, web_contents, NULL, false),

+ : BrowserPluginGuest(instance_id, false, web_contents, NULL),

update_rect_count_(0),

damage_buffer_call_count_(0),

exit_observed_(false),