Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: content/browser/browser_plugin/browser_plugin_host_browsertest.cc

Issue 11312179: C++ readability review for lazyboy@ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments (round 2). Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_host_browsertest.cc
diff --git a/content/browser/browser_plugin/browser_plugin_host_browsertest.cc b/content/browser/browser_plugin/browser_plugin_host_browsertest.cc
index 417d916e58fef857d1b339e0f8709cd935dda2f6..2dfb780a942358ce991bb30534e278c8539032d5 100644
--- a/content/browser/browser_plugin/browser_plugin_host_browsertest.cc
+++ b/content/browser/browser_plugin/browser_plugin_host_browsertest.cc
@@ -145,9 +145,9 @@ class TestShortHangTimeoutGuestFactory : public TestBrowserPluginHostFactory {
public:
virtual BrowserPluginGuest* CreateBrowserPluginGuest(
int instance_id, WebContentsImpl* web_contents) OVERRIDE {
- BrowserPluginGuest* guest =
+ TestBrowserPluginGuest* guest =
new TestBrowserPluginGuest(instance_id, web_contents);
- guest->set_guest_hang_timeout_for_testing(TestTimeouts::tiny_timeout());
+ guest->set_guest_hang_timeout(TestTimeouts::tiny_timeout());
return guest;
}
@@ -810,4 +810,5 @@ IN_PROC_BROWSER_TEST_F(BrowserPluginHostTest, DoNotCrashOnInvalidNavigation) {
EXPECT_TRUE(delegate->load_aborted_url().is_valid());
}
+
Charlie Reis 2013/11/13 19:04:28 nit: I don't think we want to add the extra line h
lazyboy 2013/11/13 19:21:11 Right, Done.
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698