content/browser/browser_plugin/browser_plugin_host_browsertest.cc - Issue 11312179: C++ readability review for lazyboy@

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/browser_plugin/browser_plugin_host_browsertest.cc

Issue 11312179: C++ readability review for lazyboy@ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Sync and reupload smaller subset for readability review. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/browser/browser_plugin/browser_plugin_guest.cc ('K') | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/browser/browser_plugin/test_browser_plugin_guest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2012 The Chromium Authors. All rights reserved.	1 // Copyright 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/command_line.h"	5 #include "base/command_line.h"

6 #include "base/memory/singleton.h"	6 #include "base/memory/singleton.h"

7 #include "base/run_loop.h"	7 #include "base/run_loop.h"

8 #include "base/strings/string_split.h"	8 #include "base/strings/string_split.h"

9 #include "base/strings/string_util.h"	9 #include "base/strings/string_util.h"

10 #include "base/strings/utf_string_conversions.h"	10 #include "base/strings/utf_string_conversions.h"

(...skipping 792 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
803	803

804 // Attempt a navigation to chrome-guest://abc123, which is a valid URL. But it	804 // Attempt a navigation to chrome-guest://abc123, which is a valid URL. But it

805 // should be blocked because the scheme isn't web-safe or a pseudo-scheme.	805 // should be blocked because the scheme isn't web-safe or a pseudo-scheme.

806 ExecuteSyncJSFunction(	806 ExecuteSyncJSFunction(

807 test_embedder()->web_contents()->GetRenderViewHost(),	807 test_embedder()->web_contents()->GetRenderViewHost(),

808 base::StringPrintf("SetSrc('%s://abc123');", kGuestScheme));	808 base::StringPrintf("SetSrc('%s://abc123');", kGuestScheme));

809 EXPECT_TRUE(delegate->load_aborted());	809 EXPECT_TRUE(delegate->load_aborted());

810 EXPECT_TRUE(delegate->load_aborted_url().is_valid());	810 EXPECT_TRUE(delegate->load_aborted_url().is_valid());

811 }	811 }

812	812

	813

813 } // namespace content	814 } // namespace content

OLD	NEW