Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Side by Side Diff: chrome/renderer/extensions/event_unittest.cc

Issue 11312157: Add ExceptionHandler to ModuleSystem, remove heap allocated v8::TryCatch. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename dispatchJSON -> dispatchEvent Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/renderer/extensions/module_system.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/base/module_system_test.h" 5 #include "chrome/test/base/module_system_test.h"
6 6
7 #include "grit/renderer_resources.h" 7 #include "grit/renderer_resources.h"
8 8
9 namespace extensions { 9 namespace extensions {
10 namespace { 10 namespace {
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 144
145 TEST_F(EventUnittest, NamedEventDispatch) { 145 TEST_F(EventUnittest, NamedEventDispatch) {
146 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get()); 146 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get());
147 RegisterModule("test", 147 RegisterModule("test",
148 "var event = require('event');" 148 "var event = require('event');"
149 "var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();" 149 "var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();"
150 "var assert = requireNative('assert');" 150 "var assert = requireNative('assert');"
151 "var e = new event.Event('myevent');" 151 "var e = new event.Event('myevent');"
152 "var called = false;" 152 "var called = false;"
153 "e.addListener(function() { called = true; });" 153 "e.addListener(function() { called = true; });"
154 "chromeHidden.Event.dispatchJSON('myevent', []);" 154 "chromeHidden.Event.dispatchEvent('myevent', []);"
155 "assert.AssertTrue(called);"); 155 "assert.AssertTrue(called);");
156 module_system_->Require("test"); 156 module_system_->Require("test");
157 } 157 }
158 158
159 TEST_F(EventUnittest, AddListenerWithFiltersThrowsErrorByDefault) { 159 TEST_F(EventUnittest, AddListenerWithFiltersThrowsErrorByDefault) {
160 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get()); 160 ModuleSystem::NativesEnabledScope natives_enabled_scope(module_system_.get());
161 RegisterModule("test", 161 RegisterModule("test",
162 "var event = require('event');" 162 "var event = require('event');"
163 "var assert = requireNative('assert');" 163 "var assert = requireNative('assert');"
164 "var e = new event.Event('myevent');" 164 "var e = new event.Event('myevent');"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 " e.addListener(cb);" 268 " e.addListener(cb);"
269 "} catch (e) {" 269 "} catch (e) {"
270 " caught = true;" 270 " caught = true;"
271 "}" 271 "}"
272 "assert.AssertTrue(caught);"); 272 "assert.AssertTrue(caught);");
273 module_system_->Require("test"); 273 module_system_->Require("test");
274 } 274 }
275 275
276 } // namespace 276 } // namespace
277 } // namespace extensions 277 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/renderer/extensions/module_system.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698