Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 11312155: cc: Rename MockContentLayerClient to FakeContentLayerClient and move to cc/test/ (Closed)

Created:
8 years, 1 month ago by danakj
Modified:
8 years, 1 month ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Rename MockContentLayerClient to FakeContentLayerClient and move to cc/test/ This class is used as a fake, not a Mock. Move it out so it possible to use this outside of layer_tree_host_unittest. Covered by existing tests. R=enne TEST=cc_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166842

Patch Set 1 #

Patch Set 2 : Extra includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -28 lines) Patch
M cc/cc_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layer_tree_host_unittest.cc View 1 18 chunks +21 lines, -28 lines 0 comments Download
A cc/test/fake_content_layer_client.h View 1 chunk +21 lines, -0 lines 0 comments Download
A cc/test/fake_content_layer_client.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danakj
8 years, 1 month ago (2012-11-08 23:14:40 UTC) #1
enne (OOO)
lgtm
8 years, 1 month ago (2012-11-09 00:13:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11312155/2001
8 years, 1 month ago (2012-11-09 00:20:34 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-09 02:19:45 UTC) #4
Change committed as 166842

Powered by Google App Engine
This is Rietveld 408576698