Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: sdk/lib/html/src/native_DOMImplementation.dart

Issue 11312122: Change List constructors. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart
Patch Set: Reupload. Adapt code for List.fixedLength. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sdk/lib/html/src/Serialization.dart ('k') | sdk/lib/io/directory_impl.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of html; 5 part of html;
6 6
7 class _Utils { 7 class _Utils {
8 static List convertToList(List list) { 8 static List convertToList(List list) {
9 // FIXME: [possible optimization]: do not copy the array if Dart_IsArray is fine w/ it. 9 // FIXME: [possible optimization]: do not copy the array if Dart_IsArray is fine w/ it.
10 final length = list.length; 10 final length = list.length;
11 List result = new List(length); 11 List result = new List.fixedLength(length);
12 result.setRange(0, length, list); 12 result.setRange(0, length, list);
13 return result; 13 return result;
14 } 14 }
15 15
16 static List convertMapToList(Map map) { 16 static List convertMapToList(Map map) {
17 List result = []; 17 List result = [];
18 map.forEach((k, v) => result.addAll([k, v])); 18 map.forEach((k, v) => result.addAll([k, v]));
19 return result; 19 return result;
20 } 20 }
21 21
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 bool get isEmpty => Maps.isEmpty(this); 106 bool get isEmpty => Maps.isEmpty(this);
107 } 107 }
108 108
109 get _printClosure => (s) { 109 get _printClosure => (s) {
110 try { 110 try {
111 window.console.log(s); 111 window.console.log(s);
112 } catch (_) { 112 } catch (_) {
113 _Utils.print(s); 113 _Utils.print(s);
114 } 114 }
115 }; 115 };
OLDNEW
« no previous file with comments | « sdk/lib/html/src/Serialization.dart ('k') | sdk/lib/io/directory_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698