Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 11312066: Android: uses an object rather than the Boolean for synchronizing LibraryLoad. (Closed)

Created:
8 years, 1 month ago by bulach
Modified:
8 years, 1 month ago
Reviewers:
joth, Sami
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Android: uses an object rather than the Boolean for synchronizing LibraryLoad. BUG=159173 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166193

Patch Set 1 #

Patch Set 2 : Remove find_bugs #

Patch Set 3 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/app/LibraryLoader.java View 1 2 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bulach
8 years, 1 month ago (2012-11-02 18:08:10 UTC) #1
Sami
lgtm. That was fast :)
8 years, 1 month ago (2012-11-02 18:12:22 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 1 month ago (2012-11-05 14:50:28 UTC) #3
joth
lgtm
8 years, 1 month ago (2012-11-06 10:22:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/11312066/9001
8 years, 1 month ago (2012-11-06 10:24:19 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-06 12:33:52 UTC) #6
Change committed as 166193

Powered by Google App Engine
This is Rietveld 408576698