Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 11312036: Call dbus_bus_register at the beginning of connection. (Closed)

Created:
8 years, 1 month ago by Seigo Nonaka
Modified:
8 years, 1 month ago
Reviewers:
satorux1
CC:
chromium-reviews
Visibility:
Public.

Description

Call dbus_bus_register at the beginning of connection. According to dbus specification in "Message Bus Messages" section (http://dbus.freedesktop.org/doc/dbus-specification.html), "Before an application is able to send messages to other applications it must send the org.freedesktop.DBus.Hello message to the message bus to obtain a unique name. " To meets this specification, we should call dbus_bus_register function which call org.freedesktop.DBus.Hello. For the dbus session or system bus, this function is called in dbus_bus_get function. BUG=159088 TEST=ran dbus_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165641

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M dbus/bus.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Seigo Nonaka
8 years, 1 month ago (2012-11-01 10:57:33 UTC) #1
satorux1
Could you file a bug? Please also add a pointer to the relevant section of ...
8 years, 1 month ago (2012-11-02 01:52:49 UTC) #2
Seigo Nonaka
Sure, done. On 2012/11/02 01:52:49, satorux1 wrote: > Could you file a bug? > > ...
8 years, 1 month ago (2012-11-02 04:05:21 UTC) #3
satorux1
LGTM
8 years, 1 month ago (2012-11-02 04:08:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11312036/3
8 years, 1 month ago (2012-11-02 04:09:22 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-02 08:04:15 UTC) #6
Change committed as 165641

Powered by Google App Engine
This is Rietveld 408576698