Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1131063006: Update whitelist for enterprise.platformKeysPrivate (Closed)

Created:
5 years, 7 months ago by Darren Krahn
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update whitelist for enterprise.platformKeysPrivate BUG=chromium:487455 TEST=None Committed: https://crrev.com/ce56d9d704ce88d131f673f8bfefcaf23387fb6e Cr-Commit-Position: refs/heads/master@{#329894}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use bug urls in comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Darren Krahn
5 years, 7 months ago (2015-05-14 00:17:13 UTC) #2
not at google - send to devlin
lgtm with comment https://chromiumcodereview.appspot.com/1131063006/diff/1/chrome/common/extensions/api/_permission_features.json File chrome/common/extensions/api/_permission_features.json (right): https://chromiumcodereview.appspot.com/1131063006/diff/1/chrome/common/extensions/api/_permission_features.json#newcode360 chrome/common/extensions/api/_permission_features.json:360: "8DAE23A10703C926B21862B2F318FB4E110B17BD" // Test Actually can we ...
5 years, 7 months ago (2015-05-14 16:28:55 UTC) #3
Darren Krahn
On 2015/05/14 16:28:55, kalman wrote: > lgtm with comment > > https://chromiumcodereview.appspot.com/1131063006/diff/1/chrome/common/extensions/api/_permission_features.json > File chrome/common/extensions/api/_permission_features.json ...
5 years, 7 months ago (2015-05-14 18:27:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131063006/20001
5 years, 7 months ago (2015-05-14 18:29:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 19:22:28 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 19:24:18 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ce56d9d704ce88d131f673f8bfefcaf23387fb6e
Cr-Commit-Position: refs/heads/master@{#329894}

Powered by Google App Engine
This is Rietveld 408576698