Issue 11308355: Change 'ok' to 'done' in WebUI where there is no corresponding 'cancel' button

Issue 11308355: Change 'ok' to 'done' in WebUI where there is no corresponding 'cancel' button (Closed)

Created:
8 years ago by please use gerrit instead

Modified:
8 years ago

Reviewers:
Dan Beam

CC:
chromium-reviews, dbeam+watch-options_chromium.org, oshima+watch_chromium.org, tfarina, dhollowa+watch_chromium.org, stevenjb+watch_chromium.org, dbeam+watch-autofill_chromium.org, arv (Not doing code reviews), dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, yusukes+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Change 'ok' to 'done' in WebUI where there is no corresponding 'cancel' button. BUG=159969 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171137

Patch Set 1 #

Patch Set 2 : 80 char lines #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -22 lines)			Patch
M	chrome/browser/resources/options/autofill_options.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/certificate_import_error_overlay.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/certificate_manager.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/chromeos/accounts_options.html	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/options/chromeos/change_picture_options.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/chromeos/language_chewing_options.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/chromeos/language_hangul_options.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/chromeos/language_mozc_options.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/chromeos/language_pinyin_options.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/chromeos/preferred_networks.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/content_settings.html	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/options/content_settings2.html	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/options/content_settings_exceptions_area.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/cookies_view.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/cookies_view_app.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/font_settings.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/handler_options.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/import_data_overlay.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/language_options.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/media_galleries_manager_overlay.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/password_manager.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/options/search_engine_manager.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/11308355/10001

8 years ago (2012-12-04 23:57:16 UTC) #3

Message was sent while issue was closed.

Change committed as 171137

Expand Messages | Collapse Messages