Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 11308354: Use SkSafeRef when claiming a ref on the SkImageFilter at the WebKit API boundary. (Closed)

Created:
8 years ago by danakj
Modified:
8 years ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org, piman, backer
Visibility:
Public.

Description

Use SkSafeRef when claiming a ref on the SkImageFilter at the WebKit API boundary. Avoids a NULL deref when then image filter is NULL. BUG=wkb.ug/103990 TBR=jamesr NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171014

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webkit/compositor_bindings/web_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
danakj
8 years ago (2012-12-04 17:40:07 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years ago (2012-12-04 18:39:19 UTC) #2
Stephen White
LGTM, but you may still need jamesr's.
8 years ago (2012-12-04 18:41:09 UTC) #3
Stephen White
On 2012/12/04 18:41:09, Stephen White wrote: > LGTM, but you may still need jamesr's. Hmm, ...
8 years ago (2012-12-04 18:42:16 UTC) #4
danakj
Oh I meant to TBR jamesr. (owner for webkit/)
8 years ago (2012-12-04 19:05:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11308354/1
8 years ago (2012-12-04 19:05:35 UTC) #6
commit-bot: I haz the power
Change committed as 171014
8 years ago (2012-12-04 19:07:23 UTC) #7
jamesr
8 years ago (2012-12-04 20:24:52 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698