Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 11308351: Remove hardcoded chromium_*.jar paths (Closed)

Created:
8 years ago by cjhopman
Modified:
8 years ago
Reviewers:
joth, nilesh
CC:
chromium-reviews, android-webview-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove hardcoded chromium_*.jar paths Targets with dependencies (direct/indirect) on a java target receive the chromium_*.jar paths in the variable input_jars_paths. Targets should use that rather than hardcoding where they think the jar will be. Change native_test_apk.xml to build with a list of jars in INPUT_JARS_PATHS rather than using all jars in a specific output directory. Make generate_native_test.py pass the --jars argument to ant with -DINPUT_JARS_PATHS. This supports those targets (WebKit) that are not updated to pass the ant-arg directly. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171131

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -39 lines) Patch
M android_webview/android_webview_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/apk_test.gypi View 3 chunks +5 lines, -8 lines 0 comments Download
M testing/android/generate_native_test.py View 1 5 chunks +10 lines, -16 lines 0 comments Download
M testing/android/native_test.gyp View 2 chunks +3 lines, -7 lines 0 comments Download
M testing/android/native_test_apk.xml View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cjhopman
nileshagrawal: testing/android, build/
8 years ago (2012-12-04 17:06:23 UTC) #1
nilesh
LGTM https://codereview.chromium.org/11308351/diff/1/testing/android/generate_native_test.py File testing/android/generate_native_test.py (right): https://codereview.chromium.org/11308351/diff/1/testing/android/generate_native_test.py#newcode186 testing/android/generate_native_test.py:186: options.ant_args.append('-DINPUT_JARS_PATHS=' + " ".join(jar_list)) Please add a comment ...
8 years ago (2012-12-04 17:24:44 UTC) #2
joth
lgtm for aw/ On 4 December 2012 09:24, <nileshagrawal@chromium.org> wrote: > LGTM > > > ...
8 years ago (2012-12-04 22:05:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/11308351/4001
8 years ago (2012-12-04 23:12:25 UTC) #4
commit-bot: I haz the power
8 years ago (2012-12-05 02:32:24 UTC) #5
Message was sent while issue was closed.
Change committed as 171131

Powered by Google App Engine
This is Rietveld 408576698