Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 11308348: Correctly show disabled Flash versions in chrome://flash. (Closed)

Created:
8 years ago by Bernhard Bauer
Modified:
8 years ago
Reviewers:
Finnur, Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Correctly show disabled Flash versions in chrome://flash. TBR=estade@chromium.org BUG=105673 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171086

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M chrome/browser/ui/webui/flash_ui.cc View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Bernhard Bauer
Please review.
8 years ago (2012-12-04 19:31:33 UTC) #1
Finnur
LGTM. Thanks for picking up the slack.
8 years ago (2012-12-04 19:37:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/11308348/1
8 years ago (2012-12-04 22:09:16 UTC) #3
commit-bot: I haz the power
Presubmit check for 11308348-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years ago (2012-12-04 22:09:18 UTC) #4
Bernhard Bauer
TBR: Evan
8 years ago (2012-12-04 22:49:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/11308348/1
8 years ago (2012-12-04 22:50:07 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-04 23:52:53 UTC) #7
Message was sent while issue was closed.
Change committed as 171086

Powered by Google App Engine
This is Rietveld 408576698