[Spellcheck] Added UMA metrics for WebKit API usage

[Spellcheck] Added UMA metrics for WebKit API usage

Part of the new metrics suggested for Spellcheck.

R=rlp@chromium.org
BUG=none.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171126

[rpetterson, 2012-12-04 02:34:09]

It looks like in a lot of these that you're counting the length of the suggested
word as opposed to, say, the number of words suggested. Is this your intention?
If so, what kinda of stats are we hoping to get from word length?

[groby-ooo-7-16, 2012-12-04 02:38:32]

All metrics should count the length of the _checked_ word, not the suggestions.

IIRC (and according to the UMA metrics doc) we wanted to know in what size text
comes through the spellcheck API. (So we can potentially take throttling
measures to protect server-side spelling from being swamped)

[rpetterson, 2012-12-04 02:59:47]

LGTM

On 2012/12/04 02:38:32, groby wrote:
> All metrics should count the length of the _checked_ word, not the
suggestions.
> 
> IIRC (and according to the UMA metrics doc) we wanted to know in what size
text
> comes through the spellcheck API. (So we can potentially take throttling
> measures to protect server-side spelling from being swamped)

[commit-bot: I haz the power, 2012-12-04 18:21:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/11308339/1

[commit-bot: I haz the power, 2012-12-04 18:21:26]

Failed to apply patch for chrome/renderer/spellchecker/spellcheck_provider.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/renderer/spellchecker/spellcheck_provider.cc
  Hunk #2 FAILED at 170.
  Hunk #3 succeeded at 167 with fuzz 1 (offset -30 lines).
  Hunk #4 succeeded at 177 (offset -30 lines).
  Hunk #5 FAILED at 215.
  Hunk #6 succeeded at 189 (offset -34 lines).
  2 out of 6 hunks FAILED -- saving rejects to file
chrome/renderer/spellchecker/spellcheck_provider.cc.rej

Patch:       chrome/renderer/spellchecker/spellcheck_provider.cc
Index: chrome/renderer/spellchecker/spellcheck_provider.cc
diff --git a/chrome/renderer/spellchecker/spellcheck_provider.cc
b/chrome/renderer/spellchecker/spellcheck_provider.cc
index
9f643b43f6e1b2dac0835b6358e0f72d734ab158..a6e0abc96ecfb72aa157040028689a9a613ee364
100644
--- a/chrome/renderer/spellchecker/spellcheck_provider.cc
+++ b/chrome/renderer/spellchecker/spellcheck_provider.cc
@@ -5,6 +5,7 @@
 #include "chrome/renderer/spellchecker/spellcheck_provider.h"
 
 #include "base/command_line.h"
+#include "base/metrics/histogram.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/spellcheck_messages.h"
 #include "chrome/common/spellcheck_result.h"
@@ -169,9 +170,11 @@ void SpellCheckProvider::spellCheck(
     spellcheck_->SpellCheckWord(
         word.c_str(), word.size(), routing_id(),
         &offset, &length, optional_suggestions ? & suggestions : NULL);
-    if (optional_suggestions)
+    if (optional_suggestions) {
+      UMA_HISTOGRAM_COUNTS("SpellCheck.api.check.suggestions", word.size());
       *optional_suggestions = suggestions;
-    if (!optional_suggestions) {
+    } else {
+      UMA_HISTOGRAM_COUNTS("SpellCheck.api.check", word.size());
       // If optional_suggestions is not requested, the API is called
       // for marking.  So we use this for counting markable words.
       Send(new SpellCheckHostMsg_NotifyChecked(routing_id(), word, 0 <
length));
@@ -196,7 +199,9 @@ void SpellCheckProvider::checkTextOfParagraph(
   if (!spellcheck_)
     return;
 
-  spellcheck_->SpellCheckParagraph(string16(text), results);
+  string16 text16(text);
+  spellcheck_->SpellCheckParagraph(text16, results);
+  UMA_HISTOGRAM_COUNTS("SpellCheck.api.paragraph", text16.size());
 #endif
 }
 
@@ -204,6 +209,7 @@ void SpellCheckProvider::requestCheckingOfText(
     const WebString& text,
     WebTextCheckingCompletion* completion) {
   RequestTextChecking(text, completion);
+  UMA_HISTOGRAM_COUNTS("SpellCheck.api.async", text.length());
 }
 
 WebString SpellCheckProvider::autoCorrectWord(const WebString& word) {
@@ -211,6 +217,7 @@ WebString SpellCheckProvider::autoCorrectWord(const
WebString& word) {
   if (command_line.HasSwitch(switches::kEnableSpellingAutoCorrect)) {
     // Will be NULL during unit tests.
     if (spellcheck_) {
+      UMA_HISTOGRAM_COUNTS("SpellCheck.api.autocorrect", word.length());
       return spellcheck_->GetAutoCorrectionWord(word, routing_id());
     }
   }
@@ -219,6 +226,7 @@ WebString SpellCheckProvider::autoCorrectWord(const
WebString& word) {
 
 void SpellCheckProvider::showSpellingUI(bool show) {
 #if defined(OS_MACOSX)
+  UMA_HISTOGRAM_BOOLEAN("SpellCheck.api.showUI", show);
   Send(new SpellCheckHostMsg_ShowSpellingPanel(routing_id(), show));
 #endif
 }

[commit-bot: I haz the power, 2012-12-05 00:02:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/11308339/7001

[commit-bot: I haz the power, 2012-12-05 02:21:30]

Change committed as 171126