Issue 11308331: [Sync] Fix NewNonFrontendDataTypeControllerTest.StartAfterSyncShutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11308331: [Sync] Fix NewNonFrontendDataTypeControllerTest.StartAfterSyncShutdown. (Closed)

Created:
8 years ago by Nicolas Zea

Modified:
8 years ago

Reviewers:
akalin

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Fix NewNonFrontendDataTypeControllerTest.StartAfterSyncShutdown. Previously the test was racy due to when the RecordUnrecoverError method expectation was set. Now that it's no longer an unrecoverable error, we can remove the expectation altogether. BUG=162793, 117796 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170893

Patch Set 1 #

Patch Set 2 : Remove exclusions #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -11 lines)			Patch
M	chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	tools/heapcheck/unit_tests.gtest-heapcheck.txt	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tools/valgrind/gtest_exclude/unit_tests.gtest-drmemory_win32.txt	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/11308331/5001

8 years ago (2012-12-03 21:23:56 UTC) #4

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests

8 years ago (2012-12-04 02:49:59 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/11308331/5001

8 years ago (2012-12-04 03:24:40 UTC) #6

Message was sent while issue was closed.

Change committed as 170893

Expand Messages | Collapse Messages