Issue 11308306: cc: Add CompositorFrame class with IPC param traits for it

Issue 11308306: cc: Add CompositorFrame class with IPC param traits for it (Closed)

Created:
8 years ago by danakj

Modified:
8 years ago

Reviewers:
jamesr, jschuh, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, backer, aelias_OOO_until_Jul13

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Add CompositorFrame class with IPC param traits for it Tests: content_unittests:CCMessagesTest.AllQuads content_unittests:CCMessagesTest.Resources BUG=152337 R=piman NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170853

Patch Set 1 #

Total comments: 1

Patch Set 2 : forlanding #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+244 lines, -28 lines)			Patch
M	cc/DEPS	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	cc/cc.gyp	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	cc/compositor_frame.h	View		1 chunk	+28 lines, -0 lines	0 comments	Download
A +	cc/compositor_frame.cc	View		1 chunk	+3 lines, -9 lines	0 comments	Download
A	cc/compositor_frame_ack.h	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A +	cc/compositor_frame_ack.cc	View		1 chunk	+3 lines, -9 lines	0 comments	Download
M	cc/transferable_resource.h	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	content/common/cc_messages.h	View		5 chunks	+38 lines, -0 lines	0 comments	Download
M	content/common/cc_messages.cc	View	1	2 chunks	+64 lines, -0 lines	0 comments	Download
M	content/common/cc_messages_unittest.cc	View		6 chunks	+79 lines, -3 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11308306/1

8 years ago (2012-12-01 19:36:54 UTC) #4

commit-bot: I haz the power

Presubmit check for 11308306-1 failed and returned exit status 1. Running presubmit commit checks ...

8 years ago (2012-12-01 19:37:02 UTC) #5

jschuh

lgtm for ipc with one change. https://chromiumcodereview.appspot.com/11308306/diff/1/content/common/cc_messages.cc File content/common/cc_messages.cc (right): https://chromiumcodereview.appspot.com/11308306/diff/1/content/common/cc_messages.cc#newcode612 content/common/cc_messages.cc:612: !ReadParam(m, iter, &num_render_passes)) ...

8 years ago (2012-12-03 19:37:24 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11308306/11001

8 years ago (2012-12-03 22:14:10 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11308306/11001

8 years ago (2012-12-04 00:50:42 UTC) #9

Message was sent while issue was closed.

Change committed as 170853

Expand Messages | Collapse Messages