Issue 11308287: [autofill] Fix crash while closing tab or browser window with interactive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11308287: [autofill] Fix crash while closing tab or browser window with interactive (Closed)

Created:
8 years ago by Dan Beam

Modified:
8 years ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, dhollowa+watch_chromium.org, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[autofill] Fix crash while closing tab or browser window with interactive autocomplete dialog open. R=isherman@chromium.org BUG=163480 TEST=close a tab or browser window with a running interactive autocomplete UI in it, no kaboom. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170392

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/autofill/autofill_manager.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/11308287/1

8 years ago (2012-11-30 01:49:19 UTC) #3

Message was sent while issue was closed.

Change committed as 170392

Expand Messages | Collapse Messages