Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 11308284: InstantExtended: Hide blank query page off NTP. (Closed)

Created:
8 years ago by Jered
Modified:
8 years ago
Reviewers:
sreeram
CC:
chromium-reviews, melevin, samarth, sreeram, gideonwald, dominich, David Black, Jered
Visibility:
Public.

Description

InstantExtended: Hide blank query page off NTP. Otherwise we show a Google logo and identity on third-party websites when the user backspaces away the query. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170758

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/instant/instant_controller.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jered
Please review. This is the last piece needed to make the overlay behave sanely on ...
8 years ago (2012-11-29 23:15:23 UTC) #1
sreeram
So I just realized that InstantController::Show() doesn't actually enforce these rules. I.e., even though we ...
8 years ago (2012-11-30 19:03:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jered@chromium.org/11308284/1
8 years ago (2012-11-30 21:51:24 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests
8 years ago (2012-12-01 00:09:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jered@chromium.org/11308284/1
8 years ago (2012-12-03 16:19:32 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) ash_unittests
8 years ago (2012-12-03 17:07:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jered@chromium.org/11308284/1
8 years ago (2012-12-03 17:19:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jered@chromium.org/11308284/1
8 years ago (2012-12-03 18:02:42 UTC) #8
commit-bot: I haz the power
8 years ago (2012-12-03 18:14:16 UTC) #9
Message was sent while issue was closed.
Change committed as 170758

Powered by Google App Engine
This is Rietveld 408576698