Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 11308278: Marked IPC::ChannelProxy as non thread-safe. Added DCHECKs to verify that all public IPC::ChannelPr… (Closed)

Created:
8 years ago by alexeypa (please no reviews)
Modified:
8 years ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, jam, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Marked IPC::ChannelProxy as non thread-safe. Added DCHECKs to verify that public methods (with Send() being the only exception) are called on the thread that created the object. Tests calling Send() from a wrong thread should be fixed first before similar check can be added to Send(). See http://crbug.com/163523 for details. BUG=163091, 163523 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171106

Patch Set 1 #

Patch Set 2 : Allow Send() to be called from any thread. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M ipc/ipc_channel_proxy.h View 2 chunks +2 lines, -1 line 0 comments Download
M ipc/ipc_channel_proxy.cc View 1 7 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
alexeypa (please no reviews)
PTAL. ipc/* - cpu@ remoting/* - wez@
8 years ago (2012-11-29 18:42:36 UTC) #1
cpu_(ooo_6.6-7.5)
does the desktop_session file need to be in this CL?
8 years ago (2012-11-29 20:16:11 UTC) #2
Wez
On 2012/11/29 20:16:11, cpu wrote: > does the desktop_session file need to be in this ...
8 years ago (2012-11-29 21:21:47 UTC) #3
alexeypa (please no reviews)
On 2012/11/29 21:21:47, Wez wrote: > On 2012/11/29 20:16:11, cpu wrote: > > does the ...
8 years ago (2012-11-29 21:36:30 UTC) #4
alexeypa (please no reviews)
Please take another look. remoting/* changes have been submitted as https://chromiumcodereview.appspot.com/11412254/. The tests are passing ...
8 years ago (2012-11-30 03:35:39 UTC) #5
alexeypa (please no reviews)
Ping.
8 years ago (2012-12-03 20:35:07 UTC) #6
cpu_(ooo_6.6-7.5)
sorry this dropped from the radar. lgtm.
8 years ago (2012-12-04 19:17:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/11308278/4002
8 years ago (2012-12-04 19:20:56 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests
8 years ago (2012-12-04 22:04:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/11308278/4002
8 years ago (2012-12-04 22:27:15 UTC) #10
commit-bot: I haz the power
8 years ago (2012-12-05 01:00:37 UTC) #11
Message was sent while issue was closed.
Change committed as 171106

Powered by Google App Engine
This is Rietveld 408576698