chrome: Extract CommandUpdaterDelegate into its own header file.

chrome/browser/command_updater.h

Index: chrome/browser/command_updater.h
diff --git a/chrome/browser/command_updater.h b/chrome/browser/command_updater.h
index 0bbbb364cde466504b5add9222094bdfd428b396..840cb030444ad2fa2f78efe089050ef856a97fb6 100644
--- a/chrome/browser/command_updater.h
+++ b/chrome/browser/command_updater.h
@@ -10,6 +10,7 @@
 #include "webkit/glue/window_open_disposition.h"
 
 class CommandObserver;
+class CommandUpdaterDelegate;
 
 ////////////////////////////////////////////////////////////////////////////////
 //
@@ -21,24 +22,10 @@ class CommandObserver;
 //
 class CommandUpdater {
  public:
-  // A Delegate object implements this interface so that it can execute commands
-  // when needed.
-  class CommandUpdaterDelegate {
-   public:
-    // Performs the action associated with the command with the specified ID and
-    // using the given disposition.
-    virtual void ExecuteCommandWithDisposition(
-        int id,
-        WindowOpenDisposition disposition) = 0;
-
-   protected:
-    virtual ~CommandUpdaterDelegate();
-  };
-
-  // Create a CommandUpdater with a CommandUpdaterDelegate to handle execution
-  // of specific commands.
-  explicit CommandUpdater(CommandUpdaterDelegate* handler);
-  virtual ~CommandUpdater();
+  // Create a CommandUpdater with |delegate| to handle the execution of specific
+  // commands.
+  explicit CommandUpdater(CommandUpdaterDelegate* delegate);
+  ~CommandUpdater();

[sky, 2012/12/06 01:38:08]

In general if there are subclasses we make the destructor virtual. While we some
times deviate from this, in general we don't.

[tfarina, 2012/12/06 01:41:40]

If I understand you, and you are concerned about that I made the destructor of
CommandUpdater non-virtual was because it doesn't have virtual methods and
NOBODY inherits from CommandUpdater.

The one inherited is CommandUpdaterDelegate and that interface has a virtual
destructor :)

Was that your concern?

 
   // Returns true if the specified command ID is supported.
   bool SupportsCommand(int id) const;
@@ -91,7 +78,6 @@ class CommandUpdater {
   typedef base::hash_map<int, Command*> CommandMap;
   CommandMap commands_;
 
-  CommandUpdater();
   DISALLOW_COPY_AND_ASSIGN(CommandUpdater);
 };