Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 11308255: Remove NPAPI target from flash_player.gyp (Closed)

Created:
8 years ago by Scott Hess - ex-Googler
Modified:
8 years ago
Reviewers:
yzshen1, viettrungluu
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove NPAPI target from flash_player.gyp BUG=161893 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/adobe/flash/flash_player.gyp View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Scott Hess - ex-Googler
I can't figure out what the official build needed this for, nor whether it should ...
8 years ago (2012-11-29 01:30:50 UTC) #1
yzshen1
I don't know either. But I thought commit-queue doesn't try the official build? Maybe you ...
8 years ago (2012-12-03 18:00:48 UTC) #2
Scott Hess - ex-Googler
Oops, I see this... at least on OSX, official builds work just fine with this ...
8 years ago (2012-12-08 01:13:31 UTC) #3
yzshen1
lgtm
8 years ago (2012-12-08 01:19:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/11308255/1
8 years ago (2012-12-12 00:03:02 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests
8 years ago (2012-12-12 03:40:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/11308255/1
8 years ago (2012-12-12 03:48:44 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests
8 years ago (2012-12-12 04:14:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/11308255/1
8 years ago (2012-12-13 23:47:14 UTC) #9
commit-bot: I haz the power
8 years ago (2012-12-14 01:11:48 UTC) #10
Message was sent while issue was closed.
Change committed as 173031

Powered by Google App Engine
This is Rietveld 408576698